[18.0][MIG] hr_expense_employee_analytic_default: Migration to 18.0

[BhaveshHeliconia]

No description provided.

[Saran440]

/ocabot migration hr_expense_employee_analytic_default

[marcelsavegnago]

LGTM

[CRogos]

Code LGTM.

3. When changing the employee, the analytical distribution will
   be updated.

When changing to a product, where no analytic distribution exists, the analytic accounts are not removed but stay with the previous distribution.

I've also tried to set a distribution for Partner "Anita Oliver", but when I select the employee "Anita Oliver" the distribution is not applied.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[CRogos]

@BhaveshHeliconia same findings like before. Did you change anything or just a rebase?

[BhaveshHeliconia]

@CRogos : Earlier I had only rebased, but now I’ve also updated the README file.

[CRogos]

I agree with the readme change, but changing the employee did not work, and also the analytic distribution did not get removed, when I change to a product without distribution template.

[BhaveshHeliconia]

I agree with the readme change, but changing the employee did not work, and also the analytic distribution did not get removed, when I change to a product without distribution template.

Okay, I’ll work on fixing that.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[BhaveshHeliconia]

@CRogos : The module now updates and clears the analytic distribution as expected when changing the employee or product, both interactively and on save. I have also added test cases for the onchange logic.
Could you please review it when you get a chance? Thanks in advance.

[CristianoMafraJunior]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[CRogos]

@BhaveshHeliconia we are currently not using this module. Therefore I am not really into it and my first test failed, most likely because I did not set the work_contact_id correct.