Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [FIX] helpdesk_ticket_close_inactive: Send warning notification only once #672

Conversation

miquelalzanillas
Copy link
Contributor

@miquelalzanillas miquelalzanillas commented Dec 23, 2024

This fix adjusts the warning email trigger for an upcoming ticket closure so that it is sent only once when there are exactly the number of days specified in the helpdesk team's configuration. Until now, the email was being sent whenever the ticket's last updated date exceeded this limit.

@ppyczko @BernatObrador @peluko00 Please review

cc https://github.com/APSL 162752

@miquelalzanillas miquelalzanillas marked this pull request as draft December 23, 2024 11:47
@miquelalzanillas miquelalzanillas marked this pull request as ready for review December 23, 2024 11:53
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

Copy link
Contributor

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@miquelalzanillas
Copy link
Contributor Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hi @miquelalzanillas. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@miquelalzanillas
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-672-by-miquelalzanillas-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1fa8bb2 into OCA:16.0 Jan 2, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d5f3b9f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants