Skip to content

[18.0][IMP] dms: Clean up attachments after creation of file #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarteo wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+9 −1
Open

[18.0][IMP] dms: Clean up attachments after creation of file #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dms/static/src/js/views/dms_file_upload.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,15 @@ export function createFileUploadExtension() {
throw new Error(attachments.error);
}

await this.onUpload(attachments);
await this.onUpload(attachments).finally(() => {
// Delete the attachments once we're done with them
const attachmentIds = attachments.map((a) => a.id);
// If the upload failed, don't waste an unlink call
if (!attachmentIds.length) {
return;
}
this.orm.call("ir.attachment", "unlink", [attachmentIds]);
});
},

async onUpload(attachments) {
Expand Down
Loading