[18.0][FIX] contract: recurring_next_date : update lines when changed on contract#1407
Closed
[18.0][FIX] contract: recurring_next_date : update lines when changed on contract#1407
Conversation
Update lines recurring next date when the contract recurring next date is modified
Contributor
Author
|
As that date has an impact on the next period end date, it make sense the date is not updated on the lines. Otherwise the period is not respected anymore. I assume the next invoice date can be changed at contract level just to set the generated invoice date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The recurring next date is editable on the contract but changing it has no impact.
The invoicing is based on the lines recurring next date which is not updated. At invoicing, a new recurring next date is recomputed based on the lines and the contract recurring next date is recomputed. So the new date is not taken into account and is lost.
Fix
Update lines recurring next date when the contract recurring next date is modified
cc @sbejaoui @florian-dacosta @pedrobaeza @etobella