[18.0][IMP] subscription_oca : add a setting to choose if the subscription …#1404
Open
[18.0][IMP] subscription_oca : add a setting to choose if the subscription …#1404
Conversation
…will start automatically when sale order is conformed or not
luisDIXMIT
approved these changes
Mar 16, 2026
Contributor
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and LGTM!
rrebollo
reviewed
Mar 24, 2026
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
From a technical perspective, LGTM.
Would you be open to adding a test covering the change you introduced to the "standard" feature? Before this PR, my understanding from the code is that every newly created subscription automatically started. Now, with your setting, that won't happen by default.
I think adding a test would be a good safety measure—let's see how it goes. You can ping me then.
Also, would you be so kind to review my #1410 in return?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…will start automatically when sale order is conformed or not