Skip to content

[18.0][IMP] contract: fix invoicing (date_ref & invoice lines) #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 2 commits into from
Mar 18, 2026
+6 −6
Merged

[18.0][IMP] contract: fix invoicing (date_ref & invoice lines) #1403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893eb9a
[IMP] contract: invoice lines
jbaudoux Mar 9, 2026
6276c8c
[FIX] contract: invoicing
jbaudoux Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions contract/models/contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,17 +598,17 @@ def _prepare_recurring_invoices_values(self, date_ref=False):
"""
invoices_values = []
for contract in self:
if not date_ref:
date_ref = contract.recurring_next_date
if not date_ref:
contract_date_ref = date_ref
if not contract_date_ref:
contract_date_ref = contract.recurring_next_date
if not contract_date_ref:
# this use case is possible when recurring_create_invoice is
# called for a finished contract
continue
contract_lines = contract._get_lines_to_invoice(date_ref)
contract_lines = contract._get_lines_to_invoice(contract_date_ref)
if not contract_lines:
continue
invoice_vals = contract._prepare_invoice(date_ref)
invoice_vals["invoice_line_ids"] = []
invoice_vals = contract._prepare_invoice(contract_date_ref)
for line in contract_lines:
invoice_line_vals = line._prepare_invoice_line()
if invoice_line_vals:
Expand Down
Loading