Skip to content

[18.0][FIX] contract_refund_on_stop - fix exception when recurring_next_date is empty #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthonissen-a wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+7 −1
Open

[18.0][FIX] contract_refund_on_stop - fix exception when recurring_next_date is empty #1394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion contract_refund_on_stop/models/contract_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def stop(self, date_end, manual_renew_needed=False, post_message=True):
or rec.last_date_invoiced <= date_end
):
continue
rec._create_refund_on_stop(
rec.with_context(refund_on_stop=True)._create_refund_on_stop(
to_refund_start_date=date_end,
to_refund_end_date=rec.last_date_invoiced,
)
Expand Down Expand Up @@ -116,3 +116,9 @@ def _get_refund_on_stop_quantity(self, to_refund_start_date, to_refund_end_date)
)
to_refund_start_date = next_period_date_end + relativedelta(days=1)
return quantity

def _insert_markers(self, first_date_invoiced, last_date_invoiced):
self.ensure_one()
if self.env.context.get("refund_on_stop"):
return _("Refund of %s", self.name)
return super()._insert_markers(first_date_invoiced, last_date_invoiced)
Loading