[11.0][MIG][ADD]-Migrated WooCommerce Module by YogeshMahera-SerpentCS · Pull Request #44 · OCA/connector-woocommerce

YogeshMahera-SerpentCS · 2018-09-30T14:57:09Z

Migrated woocommerce module with new functions
Added New functions of Import / Export of product,Sale,customer, product catergories

pedrobaeza · 2018-10-01T06:13:27Z

Hi @YogeshMahera-SerpentCS, can you please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 ?

YogeshMahera-SerpentCS · 2018-10-01T06:36:40Z

@pedrobaeza Added preserve commit history

pedrobaeza · 2018-10-01T06:40:09Z

Thanks for that, but I'm afraid you are doing the contrary: adding commit history at the end instead of the beginning. You can try the following:

Preserve current files somewhere.
Start from a clean 11.0 branch
Follow the migration guide for bringing commit history.
Add your files to this branch.
Commit again.

…nector_woocommerce as mentioned in issue JayVora-SerpentCS#3

YogeshMahera-SerpentCS · 2018-10-01T11:13:30Z

@pedrobaeza Updated Accordingly!

pedrobaeza · 2018-10-01T12:31:34Z

Great, thanks! I let now reviewers of the code itself.

YogeshMahera-SerpentCS · 2018-10-04T06:16:32Z

@simahawk @guewen Could you please check?

nogueira-raphael · 2018-10-16T21:01:07Z

I'm testing the uploaded update, and it's experiencing errors when trying to import the products.
@YogeshMahera-SerpentCS
2018-10-16 20:55:53,291 15023 ERROR =wooooo odoo.addons.queue_job.controllers.main: Traceback (most recent call last): File "/home/raphael/keesoft/apps/addons/queue/queue_job/controllers/main.py", line 97, in runjob self._try_perform_job(env, job) File "/home/raphael/keesoft/apps/addons/queue/queue_job/controllers/main.py", line 61, in _try_perform_job job.perform() File "/home/raphael/keesoft/apps/addons/queue/queue_job/job.py", line 466, in perform self.result = self.func(*tuple(self.args), **self.kwargs) File "/home/raphael/keesoft/apps/addons/connector-woocommerce/connector_woocommerce/models/woo_binding/common.py", line 51, in import_record return importer.run(external_id, force=force) File "/home/raphael/keesoft/apps/addons/connector-woocommerce/connector_woocommerce/components/importer.py", line 187, in run self.woo_record = self._get_woo_data() File "/home/raphael/keesoft/apps/addons/connector-woocommerce/connector_woocommerce/models/product/importer.py", line 75, in _create odoo_binding = super(ProductProductImporter, self)._create(data) File "/home/raphael/keesoft/apps/addons/connector-woocommerce/connector_woocommerce/components/importer.py", line 154, in _create binding = model.create(data) File "/home/raphael/keesoft/apps/addons/connector/component_event/models/base.py", line 94, in create record = super(Base, self).create(vals) File "/home/raphael/keesoft/apps/odoo/odoo/models.py", line 3373, in create record = self.browse(self._create(old_vals)) File "/home/raphael/keesoft/apps/odoo/odoo/models.py", line 3430, in _create parent_id = self.env[parent_model].create(parent_vals).id File "/home/raphael/keesoft/apps/addons/connector-ecommerce/connector_ecommerce/models/product.py", line 113, in create product = super(ProductProduct, self).create(vals) File "/home/raphael/keesoft/apps/odoo/addons/product/models/product.py", line 305, in create product = super(ProductProduct, self.with_context(create_product_product=True)).create(vals) File "/home/raphael/keesoft/apps/odoo/addons/mail/models/mail_thread.py", line 236, in create thread = super(MailThread, self).create(values) File "/home/raphael/keesoft/apps/addons/connector/component_event/models/base.py", line 94, in create record = super(Base, self).create(vals) File "/home/raphael/keesoft/apps/odoo/odoo/models.py", line 3373, in create record = self.browse(self._create(old_vals)) File "/home/raphael/keesoft/apps/odoo/odoo/models.py", line 3520, in _create field.write(self.with_context(rel_context), vals[name], create=True) File "/home/raphael/keesoft/apps/odoo/odoo/fields.py", line 2495, in write cr.execute(query, (records.ids, list(sub_ids), tuple(records.ids))) File "/home/raphael/keesoft/apps/odoo/odoo/sql_db.py", line 155, in wrapper return f(self, *args, **kwargs) File "/home/raphael/keesoft/apps/odoo/odoo/sql_db.py", line 232, in execute res = self._obj.execute(query, params) psycopg2.ProgrammingError: EXCEPT types boolean and integer cannot be matched LINE 3: ... EXCEPT (SELECT product_product_id, product_ca...

YogeshMahera-SerpentCS · 2018-10-25T05:04:16Z

@rodriguesraphael runbot is down!

angelmoya · 2018-11-27T08:44:13Z

I would be nice to get more info in readme.
Thanks

guewen · 2020-06-22T11:52:38Z

connector_woocommerce/components/exporter.py

@@ -0,0 +1,355 @@
+# © 2009 Tech-Receptives Solutions Pvt. Ltd.
+# © 2018 Serpent Consulting Services Pvt. Ltd.


The copyright on several files have been stripped, as they are strongly similar than: https://github.com/OCA/connector-magento/blob/10.0/connector_magento/components/exporter.py

guewen · 2020-06-22T11:53:53Z

connector_woocommerce/components/exporter.py

+        # record
+        if not odoo.tools.config['test_enable']:
+            binding = binding
+            #self.env.cr.commit()  # noqa


Why is the commit commented out? It's not on purpose, in the original code ;) (https://github.com/OCA/connector-magento/blob/589b62a5306d74e517c7161e9bc87d3f87172e0f/connector_magento/components/exporter.py#L107)

guewen · 2020-06-22T11:55:36Z

connector_woocommerce/components/mapper.py

+    _usage = 'export.mapper'
+
+
+def normalize_datetime(field):


this method is useless, it was for Magento which sometimes returns a date/time full of zeroes.

guewen · 2020-06-22T12:52:05Z

Very interesting :) Do you use this module in production? Do you need a lot of "local customization" to make it run with a typical woocommerce shop?

YogeshMahera-SerpentCS force-pushed the 11.0-MIG-woo_commerce branch 2 times, most recently from cb53003 to 903b841 Compare October 1, 2018 05:51

parthivgls and others added 5 commits October 1, 2018 12:19

[PATCH 1/5] [RENAME] module renamed from woocommerceerpconnect to con…

8da8f19

…nector_woocommerce as mentioned in issue JayVora-SerpentCS#3

[PATCH 2/5] [UPD] prefix versions with 8.0

ea92896

[PATCH 3/5] [MIG] Make modules uninstallable

b3d0db8

[PATCH 4/5] [SEC] connector_woocommerce: fix unsafe eval

8ee2d59

[PATCH 5/5] [MIG] Rename manifest files

7c48dbd

YogeshMahera-SerpentCS force-pushed the 11.0-MIG-woo_commerce branch from f33d1d2 to babe993 Compare October 1, 2018 06:55

[ADD/Mig]Migrated WooCommerce module and added Export functions

4c474ef

YogeshMahera-SerpentCS force-pushed the 11.0-MIG-woo_commerce branch from babe993 to 4c474ef Compare October 1, 2018 07:06

YogeshMahera-SerpentCS added 2 commits October 1, 2018 13:18

[ADD]Added OCA Dependencies

60e6008

[IMP]Improved Manifest File

a756e38

pedrobaeza added this to the 11.0 milestone Oct 1, 2018

guewen reviewed Jun 22, 2020

View reviewed changes

This was referenced Feb 2, 2021

[WIP][MIG] connector_woocommerce: Migration to 12.0 #49

Closed

12.0 mig connector woocommerce #50

Open

pniederlag mentioned this pull request Apr 23, 2021

Migration to version 11.0 #40

Open

1 task

		@@ -0,0 +1,355 @@
		# © 2009 Tech-Receptives Solutions Pvt. Ltd.
		# © 2018 Serpent Consulting Services Pvt. Ltd.

Uh oh!

Conversation

YogeshMahera-SerpentCS commented Sep 30, 2018

Uh oh!

pedrobaeza commented Oct 1, 2018

Uh oh!

YogeshMahera-SerpentCS commented Oct 1, 2018

Uh oh!

pedrobaeza commented Oct 1, 2018

Uh oh!

YogeshMahera-SerpentCS commented Oct 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Oct 1, 2018

Uh oh!

YogeshMahera-SerpentCS commented Oct 4, 2018

Uh oh!

nogueira-raphael commented Oct 16, 2018

Uh oh!

YogeshMahera-SerpentCS commented Oct 25, 2018

Uh oh!

angelmoya commented Nov 27, 2018

Uh oh!

guewen Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

guewen Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

guewen Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

guewen commented Jun 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

YogeshMahera-SerpentCS commented Oct 1, 2018 •

edited

Loading