Skip to content

[18.0][FIX] agreement_legal: remove redundant t-name from report_agreement_document#109

Open
BhaveshHeliconia wants to merge 1 commit intoOCA:18.0from
HeliconiaIO:18.0-fix-agreement_legal
Open

[18.0][FIX] agreement_legal: remove redundant t-name from report_agreement_document#109
BhaveshHeliconia wants to merge 1 commit intoOCA:18.0from
HeliconiaIO:18.0-fix-agreement_legal

Conversation

@BhaveshHeliconia
Copy link
Contributor

Issue:
The report_agreement_document template contained a redundant <t t-name="agreement.report_agreement_document"> wrapper inside the <template> tag. In modern Odoo versions, this triggers the following warning in the logs:
Unknown directives or unused attributes: {'t-name'} in agreement_legal.report_agreement_document

Reference :- OCA/sign#118

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @ygol,
some modules you are maintaining are being modified, check this out!

@BhaveshHeliconia
Copy link
Contributor Author

ping @lbarry-apsl @peluko00

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and runboat reviewed. LGTM

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BhaveshHeliconia
Copy link
Contributor Author

@pedrobaeza can we merge this?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the diff is so big?

@BhaveshHeliconia
Copy link
Contributor Author

Why the diff is so big?

The diff is large because of the pre-commit formatting changes. Some lines were reformatted. which increased the overall diff.

@pedrobaeza
Copy link
Member

That doesn't seem the problem. You have reduced an indentation level removing <t t-name="agreement.report_agreement_document">. Is that provoking any problem?

@BhaveshHeliconia
Copy link
Contributor Author

That doesn't seem the problem. You have reduced an indentation level removing <t t-name="agreement.report_agreement_document">. Is that provoking any problem?

The indentation change is due to removing . After removing that tag, I ran the pre-commit hooks, which only reformatted the file accordingly. No other changes were introduced apart from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants