[18.0][FIX] agreement_legal: remove redundant t-name from report_agreement_document#109
[18.0][FIX] agreement_legal: remove redundant t-name from report_agreement_document#109BhaveshHeliconia wants to merge 1 commit intoOCA:18.0from
Conversation
|
ping @lbarry-apsl @peluko00 |
lbarry-apsl
left a comment
There was a problem hiding this comment.
Code and runboat reviewed. LGTM
|
This PR has the |
|
@pedrobaeza can we merge this? |
The diff is large because of the pre-commit formatting changes. Some lines were reformatted. which increased the overall diff. |
|
That doesn't seem the problem. You have reduced an indentation level removing |
The indentation change is due to removing . After removing that tag, I ran the pre-commit hooks, which only reformatted the file accordingly. No other changes were introduced apart from that. |
Issue:
The
report_agreement_documenttemplate contained a redundant<t t-name="agreement.report_agreement_document">wrapper inside the<template>tag. In modern Odoo versions, this triggers the following warning in the logs:Unknown directives or unused attributes: {'t-name'} in agreement_legal.report_agreement_documentReference :- OCA/sign#118