Skip to content

[18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin#105

Open
tarteo wants to merge 1 commit intoOCA:18.0from
tarteo:18-ref-create-dynamic-content-mixin
Open

[18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin#105
tarteo wants to merge 1 commit intoOCA:18.0from
tarteo:18-ref-create-dynamic-content-mixin

Conversation

@tarteo
Copy link
Member

@tarteo tarteo commented Feb 26, 2026

We can also move the rendering to the mixin

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @ygol,
some modules you are maintaining are being modified, check this out!

Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change very much.
Could you add the module name to the PR title and commit message?

Code review LGTM, but not tested.

@tarteo tarteo changed the title [18.0][REF] Replace repeated dynamic field code with mixin [18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin Feb 26, 2026
@tarteo tarteo changed the title [18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin [18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin Feb 26, 2026
@tarteo tarteo force-pushed the 18-ref-create-dynamic-content-mixin branch from fd16a39 to d6074c7 Compare February 26, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants