Skip to content

Conversation

char0n
Copy link
Contributor

@char0n char0n commented Sep 19, 2025

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

Signed-off-by: Vladimir Gorej <[email protected]>
@char0n char0n requested review from a team as code owners September 19, 2025 19:42
@char0n char0n changed the base branch from main to v3.2-dev September 19, 2025 19:43
@ralfhandl
Copy link
Contributor

@char0n Thanks for finding this!

@ralfhandl
Copy link
Contributor

Needs forward-porting to v3.3-dev.

@ralfhandl
Copy link
Contributor

@OAI/tsc Do we want to fix this on main? Broken links are not nice.

@ralfhandl ralfhandl requested a review from a team September 20, 2025 08:13
@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Sep 20, 2025
@ralfhandl ralfhandl added this to the 3.2.1 milestone Sep 20, 2025
@ralfhandl
Copy link
Contributor

@char0n You probably need to enable actions in your fork for the required status checks to run.

@handrews
Copy link
Member

@ralfhandl We have several precedents for fixing broken links on main (including fixing all TOC links in all versions at some point), so yes, we should do this on main for 3.2.0. The TSC ruled that fixing a broken link is not a change to content back when we debated what to do about the broken TOC links.

@ralfhandl
Copy link
Contributor

The subtle difference is that we "fixed" broken links in the past by special code in the md2html script and left the source markdown files untouched.

Which I do not want to do here.

@handrews
Copy link
Member

@ralfhandl While some past breakages have been fixed that way, numerous others have not (the IETF kept breaking their own links for a while and we had to fix them, and there was some other breakage that was also directly done on main). Futhermore, the TSC decision was made when I had re-posted Mike Ralphson's PR to manually change the links. We later figured out an automated way, but that wasn't a requirement for the decision, particularly as we already had precedent for fixing other breakages.

Please, we already spent a very long time on this a couple of years ago, let's just fix the links, we already hae done this repeatedly.

@ralfhandl ralfhandl changed the title fix: fix link to Appendix F 3.2.1: fix link to Appendix F Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Wording and stylistic issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants