Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds ms extensions repo link #4304

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Jan 16, 2025

This pull request adds links to the microsoft extensions registry in the OpenAPI extensions registry for the x-ms prefix so people can better discover which extensions are defined/in use and leverage them.

ralfhandl
ralfhandl previously approved these changes Jan 18, 2025
@ralfhandl ralfhandl requested review from darrelmiller and a team January 18, 2025 09:38
@ralfhandl ralfhandl added the registries Related to any or all spec.openapis.org-hosted registries label Jan 18, 2025
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add a description with the pull request, so that anyone who doesn't have context on the work can understand and review your suggested changes.

@baywet
Copy link
Contributor Author

baywet commented Jan 20, 2025

@lornajane added

@baywet baywet requested a review from lornajane January 20, 2025 13:16
handrews
handrews previously approved these changes Jan 22, 2025
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as is, but @baywet would it make more sense to link straight to https://github.com/microsoft/OpenAPI/blob/main/extensions/index.md ?

@lornajane lornajane dismissed their stale review January 23, 2025 13:47

Outdated

registries/_namespace/ms.md Outdated Show resolved Hide resolved
registries/_namespace/ms.md Outdated Show resolved Hide resolved
@baywet baywet dismissed stale reviews from handrews and ralfhandl via bcfc9cd January 23, 2025 14:05
@baywet
Copy link
Contributor Author

baywet commented Jan 23, 2025

@lornajane thanks for the suggestion! updated.

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lornajane lornajane merged commit 9adecc3 into OAI:gh-pages Jan 23, 2025
@baywet baywet deleted the chore/add-ms-extensions-link branch January 23, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registries Related to any or all spec.openapis.org-hosted registries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants