Cleanup whitespaces in Breeze codebase #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Jan 14, 2026
|
|
||
| ∂t_ρθ_large_scale = Field{Nothing, Nothing, Center}(grid) | ||
| ∂t_θ_large_scale = - 2.5 / day # K / day | ||
| ∂t_θ_large_scale = - 2.5 / day # K / day |
Collaborator
Author
There was a problem hiding this comment.
This replaced
julia> ' '
' ': Unicode U+00A0 (category Zs: Separator, space)with
julia> ' '
' ': ASCII/Unicode U+0020 (category Zs: Separator, space)No idea how a non-breaking space ended up there in the first place.
giordano
force-pushed
the
mg/cleanup-whitespaces
branch
from
9dbe5ee to
271b9f5
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
glwagner
approved these changes
Jan 15, 2026
Collaborator
Author
navidcy
reviewed
Jan 15, 2026
navidcy
added a commit
to CliMA/Oceananigans.jl
that referenced
this pull request
Jan 15, 2026
navidcy
added a commit
to CliMA/Oceananigans.jl
that referenced
this pull request
Jan 16, 2026
* Add GitHub action to clear whitespace NumericalEarth/Breeze.jl#406 * Resolve all whitespace issues * Fix typo in nospecialize annotation * Fix typo in @nospecialize annotation --------- Co-authored-by: Mosè Giordano <m.giordano@ucl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a simple check for simple whitespace issues which is used in the Julia repo. In PRs, this annotates the offending lines in the "files changed" tab, see an example at JuliaLang/julia#55281 (comment).
A previous attempt at adding a formatting linter didn't go very far, but this is very lightweight and only about extra, or missing, whitespaces at the end of lines and similar issues, and it's even used in the Julia repo where there's traditionally some resistance to enforce heavy handed code formatters. Note: #395 would introduce 400+ more whitespace issues (which is my main motivation for this 🙃), but I can fix them all in one go with a simple elisp script if this is accepted.