Skip to content

Conversation

@Fly-Style
Copy link
Contributor

@Fly-Style Fly-Style commented Oct 24, 2024

This patch adds Verifier V1 component as a part of DVN. In case, if received Packet was not verified, Verifier executes V1 verification algorithm:

  • fetches state root from aggregator;
  • fetches block state root by chain RPC API;
  • compares them and says is message is gud.

As a part of this change:

  • Compilation error fixed in indexer tests (f61cb8b)

This change is Reviewable

coderabbitai[bot]

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as resolved.

@Nuffle-Labs Nuffle-Labs deleted a comment from coderabbitai bot Oct 25, 2024
coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Collaborator

@serrrfirat serrrfirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments - lets clarify some design decisions and small nitpicks and we can merge.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

serrrfirat
serrrfirat previously approved these changes Oct 28, 2024
Copy link
Collaborator

@serrrfirat serrrfirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment about function name. Otherwise lgtm

coderabbitai[bot]

This comment was marked as resolved.

@Nuffle-Labs Nuffle-Labs deleted a comment from coderabbitai bot Oct 28, 2024
@Fly-Style Fly-Style requested a review from serrrfirat October 28, 2024 12:14
Copy link
Contributor

@palozano palozano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Looks good overall

@Fly-Style Fly-Style merged commit 2c9fc41 into Nuffle-Labs:main Oct 28, 2024
@Fly-Style Fly-Style deleted the feat/nuf-176 branch October 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants