-
Notifications
You must be signed in to change notification settings - Fork 498
Remove documentation for deprecated NUGET_EXPERIMENTAL_USE_NJ_FOR_FILE_PARSING environment variable #3468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 63a31e4: ✅ Validation status: passedFor more details, please refer to the build report. |
…nvironment variable Co-authored-by: nkolev92 <[email protected]>
Learn Build status updates of commit 9b91d53: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit 9b91d53: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes documentation for the deprecated NUGET_EXPERIMENTAL_USE_NJ_FOR_FILE_PARSING
environment variable that was previously removed from the NuGet codebase. The environment variable was an experimental fallback mechanism for using Newtonsoft.Json instead of System.Text.Json for parsing assets files, but it was removed due to the reliability of the new parser.
- Removes the table row documenting the deprecated environment variable
- Ensures documentation accuracy by reflecting the current state of NuGet
Comments suppressed due to low confidence (1)
docs/reference/cli-reference/cli-ref-environment-variables.md:1
- There's a spelling error in the removed line: 'Netwonsoft.Json' should be 'Newtonsoft.Json'. While this line is being removed, it's worth noting the typo existed in the original documentation.
---
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes NuGet/Home#14258
This PR removes the documentation for the
NUGET_EXPERIMENTAL_USE_NJ_FOR_FILE_PARSING
environment variable, which was removed from the NuGet codebase in #14257.Background
The
NUGET_EXPERIMENTAL_USE_NJ_FOR_FILE_PARSING
environment variable was introduced in NuGet 6.10 as a fallback mechanism when the assets file parser was migrated from Newtonsoft.Json to System.Text.Json. It allowed users to revert to the old Newtonsoft.Json parser if they encountered issues with the new System.Text.Json implementation.However, no issues were reported with the System.Text.Json parser, indicating it was working reliably. As a result, the environment variable and the associated Newtonsoft.Json fallback code were removed from the NuGet codebase to reduce technical debt.
Changes
NUGET_EXPERIMENTAL_USE_NJ_FOR_FILE_PARSING
from the CLI environment variables reference pageThis ensures the documentation accurately reflects the current state of NuGet, where this experimental environment variable is no longer available.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.