This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Opt-in to transitive content flow #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeno
added a commit
to vvvv/NuGetAssemblyLoader
that referenced
this pull request
Aug 26, 2018
|
I've added two tests for the previous commit. |
kzu
reviewed
Sep 4, 2018
| @@ -34,6 +34,15 @@ public static string GetNullableMetadata(this ITaskItem taskItem, string metadat | |||
| return value; | |||
| } | |||
|
|
|||
| public static string GetContentFileInclude(this ITaskItem taskItem) | |||
There was a problem hiding this comment.
this is mixed in in this PR, it belongs to a different one that likely won't get merged soon. It would be best to separate it.
kzu
reviewed
Sep 4, 2018
| { MetadataName.Version, "8.0.0" }, | ||
| // NOTE: AssignPackagePath takes care of converting TFM > short name | ||
| { MetadataName.TargetFramework, "net45" }, | ||
| { MetadataName.IncludeAssets, "all" } |
There was a problem hiding this comment.
This should be quite useful indeed. I'd add support for ExcludeAssets too, to complete the feature.
|
Indeed - I'll rebase the branch. |
…endencies to allow transitive contentFiles flow (https://github.com/NuGet/Home/wiki/%5BSpec%5D-Managing-dependency-package-assets#nuspec)
…udeAssets specified on dependency.
azeno
force-pushed
the
contentFiles-include
branch
from
464d29e to
101e293
Compare
kzu
reviewed
Sep 4, 2018
| @@ -286,6 +289,16 @@ static VersionRange AggregateVersions(VersionRange aggregate, VersionRange next) | |||
| return versionSpec.ToVersionRange(); | |||
| } | |||
|
|
|||
| static List<string> AggregateIncludes(List<string> aggregate, string next) | |||
There was a problem hiding this comment.
Maybe rename to AggregateAssetsFlow? Since it now does Includes and Excludes?
kzu
approved these changes
Sep 5, 2018
|
thanks a lot for your contribution @azeno! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the control of the
Includeattribute for adependencywith theIncludeAssetsmetadata. See https://github.com/NuGet/Home/wiki/%5BSpec%5D-Managing-dependency-package-assets#nuspec for details.Consider ProjectA with
<ProjectReference Include="ProjectB" IncludeAssets="all" />will result in a ProjectA.nuspec with
<dependency id="ProjectB" include="all" />which when ProjectA.nuspec gets referenced will also pull in the content of ProjectB into the root project.