This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Fix broken unit test #152
Merged
Fix broken unit test #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new `[OpenBuildLog]` can be used to annotate `[Fact]/[Theory]` tests so that right after a build happens, the automatically generated .binlog is opened using Process.Start. This will only work if the viewer is installed from http://msbuildlog.com. The log is not generated unless the attribute is present, so there's no overhead unless it's used. Also, even if you forget the attribute and commit/push, on release builds, the attribute is ignored and the log is not launched.
The package cache lower cases all paths, which no longer matches the package id as we were previously doing. We need to match in a case- insensitive way therefore for private assets matching to succeed. This fixes a broken unit test that was blocking two PRs NuGet#151 and NuGet#150. Also, fix the nuget package versions at the time of this test authoring, so we don't accidentally break if newer packages ever change and cause the expectations to fail.
|
Build completed green, not sure why the status report didn't make it back here: https://ci.appveyor.com/project/MobileEssentials/nuget-build-packaging/build/0.2.0-pr152-build0013 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.