This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Added baseNuspecFile support and removed duplicate files exception #149
+37
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thorgeir, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
Could you please split the two in separate PRs for clarity and tracking purposes? That will make it easier to also discuss each one separately. Thanks! |
|
@thorgeir, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to base the nuget package of an existing nuspec file. This was possible in the NuProj projects and I've duplicated the behavior.
Also I've removed the duplicate file exception. The _PackageContent variable will contain duplicate file references when one or more project references the same files/assemblies, this should not cause an exception. Instead the duplicates are removed and the first reference is used.