Skip to content

Fix GPU assignment for Slurm-launched Ray clusters #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agolajko wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix GPU assignment for Slurm-launched Ray clusters #1592

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c48e3fc
update CVD and LOCAL_RANK assignment
agolajko Apr 29, 2026
b2d723c
handle empty get_gpu_ids list
agolajko Apr 29, 2026
97d84a5
rerun CI for test_qwen3 AssertionError
agolajko Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions skyrl/backends/skyrl_train/workers/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
ResolvedPlacementGroup,
configure_ray_worker_logging,
get_ray_pg_ready_with_timeout,
ray_noset_visible_devices,
)

_SET_AFFINITY = False
Expand Down Expand Up @@ -96,10 +95,11 @@ def __init__(
os.environ["MASTER_PORT"] = str(self._master_port)
os.environ["WORLD_SIZE"] = str(self._world_size)
os.environ["RANK"] = str(self._rank)
# NOTE: Ray will automatically set the CUDA_VISIBLE_DEVICES
# environment variable for each actor, so always set device to 0
# os.environ["LOCAL_RANK"] = str(self._local_rank)
os.environ["LOCAL_RANK"] = str(ray.get_gpu_ids()[0]) if ray_noset_visible_devices() else "0"
# Narrow CUDA_VISIBLE_DEVICES to the Ray-assigned GPU so LOCAL_RANK="0"
# is correct regardless of whether Ray or Slurm set
# CUDA_VISIBLE_DEVICES before actor init
os.environ["CUDA_VISIBLE_DEVICES"] = str(ray.get_gpu_ids()[0])
os.environ["LOCAL_RANK"] = "0"
Comment thread
agolajko marked this conversation as resolved.
Outdated
self.sequence_parallel_size: int = sequence_parallel_size

self.record_memory = record_memory
Expand Down
Loading