Open
Conversation
Add FlashAttention4Wrapper in attention.py that handles the tensor layout conversion between torchtitan's (batch, nheads, seqlen, headdim) and FA4's (batch, seqlen, nheads, headdim) format. Uses lazy import to avoid breaking users without fa4 installed. Wire up fa4 attention type in llama3, llama4, qwen3, and deepseek_v3 models. Update context parallel validation to properly block unsupported attention types. Add Qwen3 30B-A3B-fa4 and 30B-A3B-flex-causal benchmark flavors.
Block fa4 attention type with Context Parallel in qwen3 and deepseek_v3 parallelize.py, and fix llama3 args.py to use minimal denylist pattern. Add docs/fa4.md with usage, benchmark results, and limitations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.