Skip to content

Fix/multimodal remove image reencode#394

Open
radik878 wants to merge 2 commits intoNousResearch:mainfrom
radik878:fix/multimodal-remove-image-reencode
Open

Fix/multimodal remove image reencode#394
radik878 wants to merge 2 commits intoNousResearch:mainfrom
radik878:fix/multimodal-remove-image-reencode

Conversation

@radik878
Copy link

Why was this change needed?

clevr_cogen_a_train and clevr_complex were re-encoding the same image to base64 twice:

This added unnecessary CPU/memory work and relied on self.current_image shared state, which is fragile under concurrent workers.

What changed?

  • Removed image re-encoding from collect_trajectories in both envs.
  • Switched trajectory/message building to use base64_image from the input item tuple directly.
  • Kept behavior unchanged from the caller perspective, but eliminated redundant allocations and reduced risk of image/item mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant