Open
Conversation
for more information, see https://pre-commit.ci
…nto rop/weave idk
dmahan93
requested changes
Nov 10, 2025
dmahan93
requested changes
Nov 10, 2025
atroposlib/envs/README.md
Outdated
|
|
||
| Environments emit Weave traces to help you inspect rollout flow and LLM calls: | ||
|
|
||
| - Enabled by default; disable with `WEAVE_DISABLED=true`. |
Collaborator
There was a problem hiding this comment.
is it possible to put this into the config dict?
dmahan93
reviewed
Nov 14, 2025
| return "atropos" | ||
|
|
||
|
|
||
| def ensure_weave_init() -> None: |
Collaborator
There was a problem hiding this comment.
shouldn't this be populated by the group name?
for more information, see https://pre-commit.ci
…h/atropos into rop/zmq-message-pass
for more information, see https://pre-commit.ci
ZMQ Message Passing & Env Data Aggregation for WandB
Collaborator
|
@ropresearch can you merge in main? |
dmahan93
requested changes
Dec 11, 2025
atroposlib/envs/base.py
Outdated
| # Log with the base environment name | ||
| # allows overlaying all instances on one plot. | ||
| unprefixed_metrics[ | ||
| f"{self.config.desired_name}/{short_key}" |
dmahan93
requested changes
Dec 11, 2025
atroposlib/api/sidecar.py
Outdated
|
|
||
| # Otherwise treat as log payload | ||
| if wandb.run is not None: | ||
| wandb.log(payload) |
Collaborator
There was a problem hiding this comment.
this should not be controlled here, it should be routed back to the environment
Collaborator
There was a problem hiding this comment.
you will also need logic to wait for all connected environments to figure out when to send it back
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
📝 General Information
Description
Related Issues
Type of Change
✅ Developer & Reviewer Checklist