Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool page improvements #622

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Tool page improvements #622

wants to merge 4 commits into from

Conversation

AaronJackson
Copy link
Member

  • Adds an icon column indicating induction status on the tool. We'd like to add the wood lathe so that it can be booked (it's been getting a lot of use past few months), and making it clearer that it is not an induction tool would be a good thing.
  • Adds an icon to the status field if the tool is hidden. This will only be visible to those that see all the tools. Avoids having to go into the tool settings to check.
  • Adds the hidden tool checkbox to the create page as this was missing in pr Make tools hideable #596. Fixes Tool: add page missing hidden checkbox #620.

@AaronJackson
Tools: Add column with induction status icons
80dcd79 
This is to make it clearer whether a tool requires an induction or
not. We'd like to add some of the higher contention tools to HMS so
that they can be booked (the wood lathe currently).
@AaronJackson
Tools: Add icon to indicate hidden tools
165c41a
@AaronJackson
Tools: Add missing hidden checkbox. Fixes NottingHack#620
f77789c
dpslwk
dpslwk requested changes Mar 20, 2025
View reviewed changes
Copy link
Member

@dpslwk dpslwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the color style tags should really all be color: var(--primary) rather than any direct ref to #195905

@AaronJackson
Copy link
Member Author

I did wonder that but copied and pasted from elsewhere in the file. I've changed them all (including the calendar icons that were already there) to use the text-primary class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpslwk dpslwk dpslwk requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tool: add page missing hidden checkbox
2 participants
@AaronJackson @dpslwk