Install script

[Notenlish]

just clone the pr and do chmod +x install.sh and ./install.sh

[Notenlish]

@Immelancholy were you on arch? If so could you try this?

[Immelancholy]

@Immelancholy were you on arch? If so could you try this?

No I use NixOS, I can open up a docker instance with arch to do so tho.

[Immelancholy]

The script does not work, as it does not like installing pipx.

[Immelancholy]

If I install pipx manually using sudo pacman -S python-pipx it works tho. Obvs .local/bin isn't in path in this docker image but you can easily add that as a step in README like "If you get this warning just do this"

[Immelancholy]

I think it'll be a very similar situation with debian, fedora etc. Where pipx needs to be installed in the global package manager evironment.

[Immelancholy]

Just realised I never tested anifetch works holup

[Immelancholy]

Yeah so as long as the install script changes to install pipx using the distros package manager and not pip for Arch, Debian and maybe Fedora (although idk if fedora does the same shit as arch and debian) and then the user appends $HOME/.local/bin to PATH then anifetch will work perfectly as expected. If you'd like me to test the other distros in docker containers just lmk! ^-^ I'm happy to help! :3

[Immelancholy]

Sorry it took so long to get to this btw, been reallll bust with some life stuff.

[Notenlish]

Obvs .local/bin isn't in path in this docker image but you can easily add that as a step in README like "If you get this warning just do this"

Wouldn't just pipx ensurepath automatically fix this? It calls it after installing pipx.

[Notenlish]

If you'd like me to test the other distros in docker containers just lmk! ^-^ I'm happy to help! :3

Yeah that would be great if you could do that

[Immelancholy]

Obvs .local/bin isn't in path in this docker image but you can easily add that as a step in README like "If you get this warning just do this"

Wouldn't just pipx ensurepath automatically fix this? It calls it after installing pipx.

Oh maybe, idrk lol I haven't used pipx much as most of the time with NixOS if I'm installing something with python it's in its own custom python environment lol

[Immelancholy]

If you'd like me to test the other distros in docker containers just lmk! ^-^ I'm happy to help! :3

Yeah that would be great if you could do that

Nw, I'll get on it ^-^

[Immelancholy]

@Notenlish
Can confirm the install script now works with Arch and Debian (and hopefully therefore debian based distros). There was some issue with fedora where it doesn't install pipx and aborts the install process? Installed pipx manually and it worked fine again tho. The Opensuse script hangs on pipx install as well, although it's weird.

Screenshot of hanging on pipx opensuse.
I'd also recommend adding git to the deps installed in the script, as even though most will already have it, pipx does use it to download the package (Or at least the install failed once on arch cos I forgot to install it lol). Once I installed pipx manually on Fedora and Opensuse the script worked fine tho. Only suggesting the git in the install deps as curl is used to download the script in the README of this pr, and I wanted to do things as authentically as possible to what a normal user would probably do.

[Immelancholy]

Some of this could be issues with docker, but who knows.

[Immelancholy]

Sorry about taking so long btw, I got busy with my IT course. I've passed it now luckily lol. Should have some more time for stuff.

[Immelancholy]

I just took a look through the script and Python-pipx install is missing the auto confirm flag on the installations for it, I think that might be the cause of the issue with Fedora and Opensuse; adding the autoconfirm flag on Arch and Debian-based distros would also streamline the process too.

[Immelancholy]

On Arch at least you can also add the --needed flag if you want, this will basically have pacman check if the deps are already installed so will only install them if needed as opposed to reinstalling them, really tiny optimisation tho lol.

[Notenlish]

Sorry about taking so long btw, I got busy with my IT course. I've passed it now luckily lol. Should have some more time for stuff.

Nice to hear that you've passed your course

[Notenlish]

I've noted your comments, will make a new commit shortly

[Notenlish]

add the --needed flag if you want

this might be problematic if the user has old deps, im not sure about adding this

[Notenlish]

I just took a look through the script and Python-pipx install is missing the auto confirm flag on the installations for it, I think that might be the cause of the issue with Fedora and Opensuse; adding the autoconfirm flag on Arch and Debian-based distros would also streamline the process too.

I pushed a new commit, this should fix this hopefully

[Immelancholy]

add the --needed flag if you want

this might be problematic if the user has old deps, im not sure about adding this

I'm pretty sure the repo version isn't updated unless you do pacman -syu, but I could be wrong.

[Immelancholy]

I just took a look through the script and Python-pipx install is missing the auto confirm flag on the installations for it, I think that might be the cause of the issue with Fedora and Opensuse; adding the autoconfirm flag on Arch and Debian-based distros would also streamline the process too.

I pushed a new commit, this should fix this hopefully

I'll test in a bit

[Immelancholy]

Fedora:

Anifetch installs but gets this error, lowkey probably a docker thing or smthn cos of the way I set shit up. I'd probably ignore unless other people report the error too.

For Opensuse it's weird:

It's saying the --non-interactive flag is not known despite it clearly being a flag that can be added?? If I type it out in the prompt it recognises the flag. Idk what's going on there lol.

[Notenlish]

Pushed a new commit, can you check for fedora and opensuse?

[Immelancholy]

LGTM! Opensuse works perfectly. Fedora still gives this error but again I'm ngl it might just be a docker issue. It installs fine tho.

[Notenlish]

I think neofetch just might not be available in fedora since its EOL or requires sudo bcuz its eol. Should probably make a check in that util to return "not installed" if a permission issue props up. should probably also install fastfetch in install script too

[Notenlish]

nvm just made it return "permission error" and tell the user to use fastfetch instead.

[Immelancholy]

The only thing is I'm telling it to use fastfetch no?

[Notenlish]

huh

[Immelancholy]

The -ff flag is for using fastfetch instead of neofetch right? I'm using the flag when I call anifetch so idk why it's giving a perm err for neofetch :/

[Immelancholy]

and I'm making sure I install fastfetch

[Notenlish]

try this

[Immelancholy]

Aight the changes to anifetch works :3. LGTM!