-
Notifications
You must be signed in to change notification settings - Fork 29
Multi-cache #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-cache #48
Conversation
|
I don't know if it's up to date with other PRs tho! Btw, the cached files are saved with a relative or an absolute path, but both work after caching (as the file is saved in I'd like to check it first with you, but the new path system might solve #36 |
…ecting a password input
|
@supplefrog could you maybe try this version? You should directly be able to use |
|
@Gallophostrix all good now. The functionality reflected in the readme would be nice. |
Great, I'm glad it helped! For the readme file, do you mean the multi-cache functionality doesn't appear? If that's the case, I'm planning to add some further information about it 👍. Anyway, thanks for the feedback! |
Sorry for being ambiguous. I meant the functionality to use example.mp4 directly, to be documented in the readme. |
Yes, you're right, that should be added, thank you for the advice! |
|
Hey is this PR ready to be merged, are there any missing functionality etc.? |
Hey! Everything should be alright afaik 👍 |
Notenlish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the PR, this multi-cache thing works great. I will merge it once you do the fixes for the points I mentioned in my comments.
|
Sorry, I've been pretty busy the last few weeks, I'll take into account your comments and update the code accordingly 👍 |
|
Hey @Notenlish ! Could you check this update ? I added some requested changes, with some comments to your requests as well! |
|
Everything seems to be correct, but I can't merge it. There is a merge conflict in the bash script. |
|
Finally should be alright! |
|
Thanks for your contribution! |
Shoud work with the refactor (similar to #40)
I added new arguments: