Skip to content

Conversation

@Gallophostrix
Copy link
Contributor

@Gallophostrix Gallophostrix commented Jun 24, 2025

Shoud work with the refactor (similar to #40)

I added new arguments:

  • cache-list, which allows you to see all the cached files,
  • delete, which allows you to delete one cached element,
  • clear, which deletes all the cache

@Gallophostrix
Copy link
Contributor Author

Gallophostrix commented Jun 24, 2025

I don't know if it's up to date with other PRs tho!

Btw, the cached files are saved with a relative or an absolute path, but both work after caching (as the file is saved in assets). Some bugs might maybe happen if you delete the original file, not sure yet

I'd like to check it first with you, but the new path system might solve #36

@Gallophostrix
Copy link
Contributor Author

@supplefrog could you maybe try this version? You should directly be able to use example.mp4

@supplefrog
Copy link

@Gallophostrix all good now. The functionality reflected in the readme would be nice.

@Gallophostrix
Copy link
Contributor Author

@Gallophostrix all good now. The functionality reflected in the readme would be nice.

Great, I'm glad it helped!

For the readme file, do you mean the multi-cache functionality doesn't appear? If that's the case, I'm planning to add some further information about it 👍.
Or do you mean that something in the readme doesn't exist in the code?

Anyway, thanks for the feedback!

@supplefrog
Copy link

supplefrog commented Jun 30, 2025

For the readme file, do you mean the multi-cache functionality doesn't appear? If that's the case, I'm planning to add some further information about it 👍. Or do you mean that something in the readme doesn't exist in the code?

Sorry for being ambiguous. I meant the functionality to use example.mp4 directly, to be documented in the readme.

@Gallophostrix
Copy link
Contributor Author

Sorry for being ambiguous. I meant the functionality to use example.mp4 directly, to be documented in the readme.

Yes, you're right, that should be added, thank you for the advice!

@Notenlish
Copy link
Owner

Hey is this PR ready to be merged, are there any missing functionality etc.?

@Gallophostrix
Copy link
Contributor Author

Hey is this PR ready to be merged, are there any missing functionality etc.?

Hey! Everything should be alright afaik 👍

Copy link
Owner

@Notenlish Notenlish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the PR, this multi-cache thing works great. I will merge it once you do the fixes for the points I mentioned in my comments.

@Gallophostrix
Copy link
Contributor Author

Sorry, I've been pretty busy the last few weeks, I'll take into account your comments and update the code accordingly 👍

@Gallophostrix
Copy link
Contributor Author

Hey @Notenlish ! Could you check this update ? I added some requested changes, with some comments to your requests as well!

@Notenlish
Copy link
Owner

Everything seems to be correct, but I can't merge it. There is a merge conflict in the bash script.

@Gallophostrix
Copy link
Contributor Author

Finally should be alright!

@Notenlish
Copy link
Owner

Thanks for your contribution!

@Notenlish Notenlish merged commit d7d586c into Notenlish:main Jul 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants