Forms 1.0.15: Fix null value handling and form submission error detection#725
Merged
dwertheimer merged 2 commits intomainfrom Jan 19, 2026
Merged
Conversation
- Fixed critical null value handling in JSP/getFilteredProps/getAllPropertyNames functions to prevent 'TypeError: null is not an object' errors - Fixed form submission success detection - undefined is now treated as success when templateRunner creates a note (was incorrectly flagged as error) - Added deep null sanitization throughout form data processing - Made templateNew return filename for API consistency - Updated templateRunner to return filename on successful note creation - Removed setTimeout usage (not available in NotePlan JSContext) - Improved error messages for better debugging Version bump to 1.0.15
… error handling - Moved getFolders, getNotes, getEvents, getHashtags, getMentions, getTeamspaces from requestHandlers.js to new dataHandlers.js to break circular dependencies - Moved RequestResponse type to shared/types.js for better type sharing - Improved error handling in FormBrowserView for form submission responses - Updated imports across affected files
dwertheimer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical issues with null value handling and form submission error detection.
Changes
Fixed
TypeError: null is not an object (evaluating 'Object.getOwnPropertyNames')error that occurred when templating plugin tried to process form data containing null values. Added explicit null checks inJSP,getFilteredProps, andgetAllPropertyNameshelper functions.templateRunnersuccessfully creates a note, it returnsundefined(which is valid), but the code was treating this as an error.setTimeoutusage (not available in NotePlan's JSContext).Changed
nullon failure for API consistency.Testing
Version
Bumped to 1.0.15