Preview styling improvements (tables, HRs etc)#696
Conversation
jgclark
left a comment
There was a problem hiding this comment.
Thanks, David. My only comment is to suggest you move the new hexToRgb() function to live in helpers/colors.js, so that can be re-used more easily.
(Come to think of it, I think you've used some sort of chroma library in the past. Does that not have this sort of function already?)
|
Good suggestions. Moved to colors and used chroma. |
|
@jgclark in Discord concluded that: @jgclark You may want to scrap this PR and the code changes and start fresh depending on how you want to implement I used to think that Preview was a short-term need, but after Eduard rolled back the Mermaid attempt in published pages, I think for me, Preview is going to be necessary for the indefinite future. |
|
@jgclark Nevermind this PR. I am going to start a new one |
No description provided.