Skip to content

Comments

Preview styling improvements (tables, HRs etc)#696

Closed
dwertheimer wants to merge 3 commits intomainfrom
preview-styling
Closed

Preview styling improvements (tables, HRs etc)#696
dwertheimer wants to merge 3 commits intomainfrom
preview-styling

Conversation

@dwertheimer
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@jgclark jgclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, David. My only comment is to suggest you move the new hexToRgb() function to live in helpers/colors.js, so that can be re-used more easily.
(Come to think of it, I think you've used some sort of chroma library in the past. Does that not have this sort of function already?)

@dwertheimer
Copy link
Collaborator Author

Good suggestions. Moved to colors and used chroma.

@dwertheimer
Copy link
Collaborator Author

@jgclark in Discord concluded that:
"I'm not keen on having table/th/tr/td in ThemeToCSS"
a) the CSS classes should probably be scoped to be Preview-specific
b) Or, potentially, a slightly more general "EditorLayout" class, as that's what you're trying to mimic, I think.

@jgclark You may want to scrap this PR and the code changes and start fresh depending on how you want to implement

I used to think that Preview was a short-term need, but after Eduard rolled back the Mermaid attempt in published pages, I think for me, Preview is going to be necessary for the indefinite future.

@dwertheimer
Copy link
Collaborator Author

@jgclark Nevermind this PR. I am going to start a new one

@dwertheimer dwertheimer closed this Nov 7, 2025
@dwertheimer dwertheimer deleted the preview-styling branch November 7, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants