Implement new '/Remove empty elements from recent notes' command#694
Merged
Implement new '/Remove empty elements from recent notes' command#694
Conversation
…update plugin version to 1.16.0. Adjust error handling in template rendering and improve documentation in README and CHANGELOG.
Collaborator
|
@jgclark This does not work properly for me. I am going to have to recover all my notes from backup. I just ran it and it, and for instance, this note: 
ended up with one blank todo on the page 
Log for that one example: |
Collaborator
|
The full log: |
Collaborator
Author
Major ouch. Sorry to hear this. So, I assumed the basic function was working for you, and I was just extending it to:
From the screenshot I can see that (in the terms of this function) you have a number of headings without any content -- e.g. lines 3 and 6. So I'd expect those to get removed. And the empty task should be removed, but no others. I will look further at this as first priority. |
Collaborator
Author
|
I've tested on your note content copied into a test regular note and it works OK. |
…ePlan/plugins into feat-tidy-recent-notes-a0bd7
Collaborator
|
@jgclark I am still trying to find the rhyme/reason for the deleted notes I reported above but a couple of observations in the meantime...
And it (correctly) removed everything in the note
In retrospect, I wonder if it should at least keep a line 1 heading/title in this case -- we certainly would in the case of a project note. Maybe we should do the same with Calendar notes. Would love your thoughts on that?
becomes: 
|
Collaborator
|
I have just run the command on many individual notes and it works as advertised. I cannot re-create this bug I reported previously, and I'm not sure what to do about it. So I added in some code that does a sanity check looking for meaningful content that should not have been wiped out but the note was emptied. See what you think. 
|
Collaborator
|
@jgclark One highly problematic thing that I just noticed is that it deletes the content from @templates also (and many are by-design devoid of content under headings). So it definitely needs to ignore @templates in its scan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#691 for plugin version to 1.16.0.