add trigger as well as make silent run more silent'er#631
Closed
cwhittl wants to merge 2 commits intoNotePlan:mainfrom
Closed
add trigger as well as make silent run more silent'er#631cwhittl wants to merge 2 commits intoNotePlan:mainfrom
cwhittl wants to merge 2 commits intoNotePlan:mainfrom
Conversation
jgclark
requested changes
Mar 18, 2025
Collaborator
jgclark
left a comment
There was a problem hiding this comment.
I still think adding this trigger isn't the best way to solve this particular problem -- instead use a template to call existing command on daily or weekly notes -- but I'm happy to include it. It does have the advantage of running more frequently for most people, though it has the down-side of lots of repetitive work that may slow the app down.
Changes requested:
- document in the README
- why hard-code to 4 days? There's a "How many days to count as recent?" setting which I think you should re-use here. Though I realise its description will need changing a little as this is not a "Remove ... recent ..." command.
Collaborator
|
@cwhittl Do you want to keep the conversation going here or should we close the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a trigger capability that allows generating repeats for notes from the past four days when working within a calendar note. This feature is not recommended for regular notes, refer to the repeat extension for that use case.
The trigger line is:
triggers: onEditorWillSave => np.Tidy.generateRepeatsFromRecentNotes.