Merged
Conversation
Collaborator
|
Merging branch after visual inspection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jgclark Pls have a look. I found (as noted in the Dashboard note) that when you click on the last item in a section the section does not go away. I think this is because the section is not getting overwritten in the refresh because items is blank and therefore a section is not produced and therefore the old section is not overwritten. I went through and changed this in all the dataGens I could find. I took out the ( if items.length > 0 then push section) parenthetical and add the section in all cases so it will overwrite the old one with a new section with no sectionItems on refresh.
Please test in this branch.