Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

Add new model providers#85

Merged
dragos199993 merged 4 commits into
mainfrom
ENG-2409_support-latest-models
May 30, 2025
Merged

Add new model providers#85
dragos199993 merged 4 commits into
mainfrom
ENG-2409_support-latest-models

Conversation

@dragos199993

Copy link
Copy Markdown
Member

No description provided.

@r0ymanesco

Copy link
Copy Markdown
Contributor

Related to my comments in the nd-server PR, we need to add both the alias and the dated versions of models

r0ymanesco
r0ymanesco previously approved these changes May 29, 2025

@r0ymanesco r0ymanesco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock but can you add tests for these? I think there is one test that should automatically run these models in which case make sure you record the cassettes?

@github-actions

github-actions Bot commented May 30, 2025

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  notdiamond/llms
  providers.py
  tests/test_llm_calls
  test_openai.py
Project Total  

This report was generated by python-coverage-comment-action

@dragos199993 dragos199993 merged commit 0d8d3fb into main May 30, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants