Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

refactor: update model references and remove deprecated models#110

Merged
dragos199993 merged 1 commit into
mainfrom
ENG-3942_remove-deprecated-models
Nov 6, 2025
Merged

refactor: update model references and remove deprecated models#110
dragos199993 merged 1 commit into
mainfrom
ENG-3942_remove-deprecated-models

Conversation

@dragos199993

@dragos199993 dragos199993 commented Nov 6, 2025

Copy link
Copy Markdown
Member
  • Removed references to claude-2.1 and gemini-pro from settings and provider files.
  • Updated tests to use new models: claude-haiku-4-5-20251001 and gemini-2.5-pro.
  • Cleaned up test cassettes and documentation to reflect the changes in model support.

Note

Replaces deprecated Anthropic and Google models with latest Anthropic 4.x (haiku/sonnet/opus) and Gemini 2.5 variants across code, settings, tests, and docs.

  • LLM model roster:
    • Remove anthropic/claude-2.1, google/gemini-pro, google/gemini-1.0/1.5-pro-latest.
    • Add/standardize anthropic/claude-haiku-4-5(-20251001), claude-sonnet-4-5(-20250929), claude-opus-4-1(-20250805), and google/gemini-2.5-pro.
    • Update settings.py model lists, openrouter_identifier, pricing, and support_response_model accordingly.
  • Providers/Enums: Align NDLLMProviders with new Anthropic/Gemini variants; drop deprecated entries.
  • Tests & cassettes:
    • Switch all selections and assertions to new model IDs; refresh recorded responses (UA/version headers, session/latency statuses).
    • Adjust tool schemas usage; skip obsolete Anthropic "no-tools" test.
  • Docs/examples: Update LangChain/usage examples to new model identifiers.

Written by Cursor Bugbot for commit 68e0144. Configure here.

- Removed references to claude-2.1 and gemini-pro from settings and provider files.
- Updated tests to use new models: claude-haiku-4-5-20251001 and gemini-2.5-pro.
- Cleaned up test cassettes and documentation to reflect the changes in model support.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR


llm_configs = [
"anthropic/claude-2.1",
"anthropic/claude-opus-4-1-20250805",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Contradictory Test Logic on Tool Support Scenario

The test test_ndllm_tool_calling_unsupported_model has contradictory logic. It immediately skips with the message "All current Anthropic models support tools", but then contains unreachable code that expects the model "anthropic/claude-opus-4-1-20250805" to NOT support tools and raise an ApiError. Since Claude Opus 4 does support tools, the test should either be removed entirely or refactored to test a different scenario. The current implementation leaves dead code that expects behavior opposite to the skip reason.

Fix in Cursor Fix in Web

@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  notdiamond/llms
  client.py
  providers.py
  notdiamond/toolkit
  custom_router.py
  notdiamond/toolkit/rag
  evaluation.py
  testset.py
  workflow.py
  tests/test_components/test_llms
  test_llm.py 237-244, 448-452, 990-999
  test_provider.py
  tests/test_documentation
  test_personalization.py
  tests/test_llm_calls
  test_anthropic.py
  test_google.py 13-15, 25, 28-30, 40, 43-45, 54, 57-59, 68, 71-73, 83, 86-88, 98, 101-103, 120-122, 134, 137-139, 155-157, 168, 171-173
  tests/test_toolkit/langchain
  test_unit.py
  tests/test_toolkit/rag
  test_data_gen.py
  test_example_workflow.py
Project Total  

This report was generated by python-coverage-comment-action

@dragos199993 dragos199993 merged commit fdc6540 into main Nov 6, 2025
6 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants