This repository was archived by the owner on Dec 11, 2025. It is now read-only.
refactor: update model references and remove deprecated models#110
Merged
Conversation
- Removed references to claude-2.1 and gemini-pro from settings and provider files. - Updated tests to use new models: claude-haiku-4-5-20251001 and gemini-2.5-pro. - Cleaned up test cassettes and documentation to reflect the changes in model support.
|
|
||
| llm_configs = [ | ||
| "anthropic/claude-2.1", | ||
| "anthropic/claude-opus-4-1-20250805", |
There was a problem hiding this comment.
Bug: Contradictory Test Logic on Tool Support Scenario
The test test_ndllm_tool_calling_unsupported_model has contradictory logic. It immediately skips with the message "All current Anthropic models support tools", but then contains unreachable code that expects the model "anthropic/claude-opus-4-1-20250805" to NOT support tools and raise an ApiError. Since Claude Opus 4 does support tools, the test should either be removed entirely or refactored to test a different scenario. The current implementation leaves dead code that expects behavior opposite to the skip reason.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
r0ymanesco
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Replaces deprecated Anthropic and Google models with latest Anthropic 4.x (haiku/sonnet/opus) and Gemini 2.5 variants across code, settings, tests, and docs.
anthropic/claude-2.1,google/gemini-pro,google/gemini-1.0/1.5-pro-latest.anthropic/claude-haiku-4-5(-20251001),claude-sonnet-4-5(-20250929),claude-opus-4-1(-20250805), andgoogle/gemini-2.5-pro.settings.pymodel lists,openrouter_identifier, pricing, andsupport_response_modelaccordingly.NDLLMProviderswith new Anthropic/Gemini variants; drop deprecated entries.Written by Cursor Bugbot for commit 68e0144. Configure here.