Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

refactor: remove deprecated references to claude-3-sonnet-20240229#109

Merged
dragos199993 merged 1 commit into
mainfrom
ENG-3941_remove-sonnet-3
Nov 5, 2025
Merged

refactor: remove deprecated references to claude-3-sonnet-20240229#109
dragos199993 merged 1 commit into
mainfrom
ENG-3941_remove-sonnet-3

Conversation

@dragos199993

@dragos199993 dragos199993 commented Nov 5, 2025

Copy link
Copy Markdown
Member
  • Removed all instances of claude-3-sonnet-20240229 from settings.py, providers.py, and test files.
  • Updated tests to use the new claude-sonnet-4-5-20250929 model.
  • Deleted obsolete test cassettes related to the removed model.

Note

Remove all references to claude-3-sonnet-20240229, update tests to claude-sonnet-4-5-20250929, delete obsolete cassettes, and harden API error parsing.

  • Core:
    • Remove claude-3-sonnet-20240229 from notdiamond/llms/providers.py and notdiamond/settings.py (models, support_tools, openrouter_identifier, price).
    • Improve API error handling in notdiamond/llms/request.py::model_select_parse to parse error.message and fallback formats.
  • Tests/Docs:
    • Replace anthropic/claude-3-sonnet-20240229 with anthropic/claude-sonnet-4-5-20250929 across documentation tests and LangChain integration tests.
    • Remove test cases specifically for claude-3-sonnet-20240229 and delete associated VCR cassettes.
    • Keep remaining Anthropic tests (opus, haiku, sonnet variants) unchanged.

Written by Cursor Bugbot for commit 4698582. Configure here.

- Removed all instances of claude-3-sonnet-20240229 from settings.py, providers.py, and test files.
- Updated tests to use the new claude-sonnet-4-5-20250929 model.
- Deleted obsolete test cassettes related to the removed model.
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  notdiamond/llms
  providers.py
  request.py 128
  notdiamond/toolkit
  custom_router.py
  notdiamond/toolkit/rag
  evaluation.py
  testset.py
  workflow.py
  tests/test_llm_calls
  test_anthropic.py
  tests/test_toolkit/rag
  test_data_gen.py
  test_example_workflow.py
Project Total  

This report was generated by python-coverage-comment-action

@dragos199993 dragos199993 merged commit 39ce6b5 into main Nov 5, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants