exec: security_auth_bans — complete load persistent ban list #98
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| def _update_jukeboxes() -> None: | ||
| for obj in list(object_registry): | ||
| if obj.item_type != int(ItemType.JUKEBOX): | ||
| continue | ||
|
|
||
| values = obj.value | ||
| if len(values) < 5: | ||
| values.extend([-1] * (5 - len(values))) | ||
|
|
||
| current_song_index = values[1] | ||
| if current_song_index < 0: | ||
| continue |
There was a problem hiding this comment.
_update_jukeboxes scans object_registry for jukeboxes, but nothing ever populates that registry in the Python object system – spawn_object returns mud.models.object.Object instances and never appends them to mud.models.obj.object_registry. As a result, the new music tick will never process real world jukeboxes and no lyrics will broadcast in game play despite the added tests. Consider tracking spawned objects in the same registry (or iterating room contents/inventories directly) so the periodic song update actually sees objects created by resets and players.
Useful? React with 👍 / 👎.
Summary
ban.txtentriesTesting
ruff check . && ruff format --check .(fails: pre-existing whitespace/import issues across scripts and tests)mypy --strict .(fails: repository-wide missing type hints and stub packages)pytest -q(fails: baseline combat, nanny, and mobprog regressions prior to this change)PYTHONPATH=. pytest tests/test_account_auth.py::test_permanent_ban_survives_restart -qhttps://chatgpt.com/codex/tasks/task_b_68df0b5ef7248320a0bed62bac5cb23f