Merge pull request #883 from NordicSemiconductor/fix/insights-send-br…

…owser-data-on-opt-out

Fix: sending browser info after opting out

Changelog.md

@@ -7,6 +7,13 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 155.0 - 2024-02-05
+
+### Fix
+
+-   Disable Azure Insights when opting out to avoid leaking off browser
+    information.
+
 ## 154.0.0 - 2024-02-05
 
 ### Changed

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "154.0.0",
+    "version": "155.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

src/telemetry/TelemetrySender.ts

@@ -42,6 +42,8 @@ export default abstract class TelemetrySender {
 
     sendDisagreementEvent() {
         this.sendMinimalEvent('Telemetry Opt-Out');
+        this.flush();
+        this.stop();
     }
 
     async setUsersAgreedToTelemetry(hasAgreed: boolean) {
@@ -77,4 +79,5 @@ export default abstract class TelemetrySender {
     abstract sendTrace(message: string): MaybePromise<void>;
     abstract sendErrorReport(error: Error): MaybePromise<void>;
     abstract flush(): MaybePromise<void>;
+    abstract stop(): void;
 }

src/telemetry/TelemetrySenderInMain.ts

@@ -77,4 +77,11 @@ export default class TelemetrySenderInMain extends TelemetrySender {
     };
 
     flush = () => this.getClient().flush();
+
+    stop(): void {
+        if (this.client) {
+            this.client.config.disableAppInsights = true;
+        }
+        this.client = undefined;
+    }
 }

src/telemetry/TelemetrySenderInRenderer.ts

@@ -83,4 +83,12 @@ export default class TelemetrySenderInRenderer extends TelemetrySender {
     };
 
     flush = async () => (await this.getClient()).flush();
+
+    stop(): void {
+        if (this.client) {
+            this.client.config.disableTelemetry = true;
+            this.client?.unload();
+        }
+        this.client = undefined;
+    }
 }