Skip to content

Conversation

@gold2718
Copy link
Contributor

@gold2718 gold2718 commented Dec 11, 2025

In order to run SST experiments in the Kurosio Current region, two input files are required. See NorESMhub/NorESM#737 for details. This PR adds namelist entries for these two files.

No tests run, however, namelist_definition_blom.xml validated against schema, cime_config/ParamGen/xml_schema/entry_id_pg.xsd

@gold2718 gold2718 self-assigned this Dec 11, 2025
@gold2718 gold2718 added the enhancement New feature or request label Dec 11, 2025
@gold2718
Copy link
Contributor Author

@TomasTorsvik, one idea to make these more general would be to rename them pacemaker_SST_file and pacemaker_mask_file because they can be used to study other regions (and times) if different input files are used. Thoughts?
@hra063

@TomasTorsvik
Copy link
Contributor

@TomasTorsvik, one idea to make these more general would be to rename them pacemaker_SST_file and pacemaker_mask_file because they can be used to study other regions (and times) if different input files are used. Thoughts? @hra063

@gold2718 , @hra063 - I agree with the suggestion to use the more general terms pacemaker_SST_file and pacemaker_mask_file.

@gold2718 gold2718 moved this from Todo to In Progress in NorESM Development Dec 11, 2025
@TomasTorsvik
Copy link
Contributor

@gold2718 - Looks fine to me, but maybe the description text can also be more general?

suggestions from @TomasTorsvik

Co-authored-by: Tomas Torsvik <[email protected]>
@gold2718
Copy link
Contributor Author

Thanks @TomasTorsvik, I have commited these changes (thanks to the new batch review processing feature on GitHub)

@TomasTorsvik
Copy link
Contributor

@gold2718 - I think this can be merged now. It should come in as tag v1.4.5.

@gold2718
Copy link
Contributor Author

Thanks @TomasTorsvik, I have commited these changes (thanks to the new batch review processing feature on GitHub)

I take it back. The GitHub suggestion auto-commit mangled the text and introduce an XML syntax error in the process. Back to manual editing :(

@gold2718 gold2718 merged commit 4b7a8e1 into NorESMhub:release-1.4 Dec 12, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in NorESM Development Dec 12, 2025
@gold2718 gold2718 deleted the pacemaker branch December 12, 2025 11:27
@gold2718
Copy link
Contributor Author

@gold2718 - I think this can be merged now. It should come in as tag v1.4.5.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants