Conversation
youjin09222
approved these changes
Apr 23, 2025
Contributor
youjin09222
left a comment
youjin09222
left a comment
There was a problem hiding this comment.
엄청 까다로웠을 텐데 진짜 고생 많았으어🥺
Contributor
There was a problem hiding this comment.
P3: 체크박스 컴포넌트로 따로 빼놓은거 너무 좋습니다!
| NoostakAndroidTheme { | ||
| NoostakCheckbox( | ||
| isChecked = true, | ||
| text = "체크박스블라블라" |
| isChecked = isChecked, | ||
| onCheckedChange = { | ||
| isChecked = it | ||
| if (isChecked) selectedData = emptyList() |
Contributor
There was a problem hiding this comment.
P3: 오호 체크 박스 선택 시 이렇게 초기화했구나! 베리굿!
| return false | ||
| } | ||
|
|
||
| val sorted = selectedDate.sortedBy { LocalDateTime.parse(it.startTime) } |
Contributor
There was a problem hiding this comment.
P3: 시간 정렬하는 방법 너무 좋은디!
Comment on lines
+108
to
+112
| val finalBlockDuration = Duration.between(currentStart, currentEnd).toHours() | ||
| if (finalBlockDuration < duration) { | ||
| emitSideEffect(AppointmentCheckSideEffect.ShowSnackBar(R.string.sb_appointment_check_invalid)) | ||
| return false | ||
| } |
Contributor
There was a problem hiding this comment.
P3: 마지막 블록까지 꼼꼼히 체크한 거 너무 좋습니다!
Comment on lines
+91
to
+107
| for (i in 1 until sorted.size) { | ||
| val nextStart = LocalDateTime.parse(sorted[i].startTime) | ||
| val nextEnd = LocalDateTime.parse(sorted[i].endTime) | ||
|
|
||
| if (nextStart == currentEnd) { | ||
| currentEnd = nextEnd | ||
| } else { | ||
| // 블록이 끊기면 검사 | ||
| val blockDuration = Duration.between(currentStart, currentEnd).toHours() | ||
| if (blockDuration < duration) { | ||
| emitSideEffect(AppointmentCheckSideEffect.ShowSnackBar(R.string.sb_appointment_check_invalid)) | ||
| return false | ||
| } | ||
| currentStart = nextStart | ||
| currentEnd = nextEnd | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
P3: 오 이렇게 연속 여부 판단했구나 대단한디?
Contributor
Author
There was a problem hiding this comment.
지피티는 정말 대단한 친구야 흙흙
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
default.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
체크박스 컴포넌트 만들어서 하늘언니 약속 생성 부분 코드 수정했어요 @twogarlic