Fix singletons created during dispose #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
susch19
commented
Nov 13, 2024
susch19
commented
- because we accessed the instance to check if it is disposable and created the instance during this, so now we have a method on the TypeInformation that can access the singletonInstance directly without lazy creating it
Gallimathias
approved these changes
Nov 13, 2024
* because we accessed the instance to check if it is disposable and created the instance during this, so now we have a method on the TypeInformation that can access the singletonInstance directly without lazy creating it
susch19
force-pushed
the
fix/typeContainerDispose
branch
from
293556d to
c8770c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.