FileManager fixes for Windows.#53
Merged
Nomagno merged 2 commits intoNomagno:tyre2X-devfrom Apr 2, 2026
Merged
Conversation
Consistent with 6c23f94. I suspect more like this commit should come. Updating addons using unofficial links should now work on Windows as the proper implementation of removeDirectory is now the one compiled.
…lly to different disks. This fix is compatible with C++17 and later only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 9d8cecc makes file_manager.cpp detect compiling for Windows and compile the correct implementations. This fixes a bug (introduced in the command-manager fork) when updating existing addons using unofficial links on Windows.
Commit f8ed20e fixes linked directory issues by replacing
MoveFileExWwithstd::filesystem::copyand::remove_all(notice the#include <filesystem>) to allow the filemanager to follow NTFS Junctions (microsoftese for "hard links"), which are for some reason detected as normal directories bystd::filesystem::statusand due to microsoft's incompetence are almost completely impossible to use or resolve with the Win32 API functions at least with normal user privileges.This fix is C++17 and later only and is thus incompatible with upstream STK 1.x and 2.x.
Agreement