Skip to content

Marking NobleSprite with animation dirty before drawing #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stiv-iv wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Marking NobleSprite with animation dirty before drawing #65

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7c5666
Marking NobleSprite with animation dirty before drawing
stiv-iv Nov 1, 2023
16c5257
Merge remote-tracking branch 'upstream/main'
stiv-iv Nov 24, 2023
48447e5
Last redrawing sprite in pause() and stop() methods
stiv-iv Dec 13, 2023
b034300
Fix tabulation format
stiv-iv Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion modules/NobleSprite.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,17 @@ function NobleSprite:init(__view, __viewIsSpritesheet, __singleState, __singleSt

end

function NobleSprite:update()
if (self.animation ~= nil) then
self:markDirty()
end
end

function NobleSprite:draw(__x, __y)
if (self.animation ~= nil) then
local x = __x or 0
local y = __y or 0
self.animation:draw(x, y)
self:markDirty()
end
end

Expand All @@ -114,13 +119,17 @@ end
--- This will disable the update loop for this NobleSprite, which also causes its Noble.Animation to pause.
function NobleSprite:pause()
self:setUpdatesEnabled(false)
if (self.animation ~= nil) then
self:markDirty()
end
end

--- This will disable the update loop for this NobleSprite, and also reset its Noble.Animation (if it exists) to the first frame of its current state.
function NobleSprite:stop()
self:setUpdatesEnabled(false)
if (self.animation ~= nil) then
self.animation.currentFrame = self.animation.current.startFrame
self:markDirty()
end
end

Expand Down