Tooltip on Hover #25
Tooltip on Hover #25
Conversation
| "antiPatternMessage": "Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: " | ||
| "antiPatternMessage": "Single operation found in loop. This SDK provides a batch operation API, use it to perform multiple actions in a single request: ", | ||
| "recommendationText": "A a batch operation API exists in the SDK that can handle multiple actions in one request.", | ||
| "recommendationLink": "" |
There was a problem hiding this comment.
will ask for link from Shawn
There was a problem hiding this comment.
yes-- I messaged him about it, so just waiting to hear back
| Please refer to | ||
| the [KeyCredential Class documentation](https://learn.microsoft.com/java/api/com.azure.core.credential.keycredential?view=azure-java-stable) | ||
| for more information. | ||
| for more information. |
There was a problem hiding this comment.
these strings are the exact same, including number of spaces so I'm not sure how it's in the diff
There was a problem hiding this comment.
figured out it comes from the line break so its not problematic
| import javax.swing.text.html.StyleSheet; | ||
|
|
||
| /** | ||
| * This class is used to create a custom quick fix that shows a tooltip with a recommendation text and a link to the Azure SDK for Java documentation. |
There was a problem hiding this comment.
| * This class is used to create a custom quick fix that shows a tooltip with a recommendation text and a link to the Azure SDK for Java documentation. | |
| * This class is used to create a tooltip with a recommendation text and a link to the Azure SDK for Java documentation. |
| * @return The name of the quick fix. | ||
| */ | ||
| @Override | ||
| public @NotNull String getName() { |
There was a problem hiding this comment.
Will this be updated in the future to get "the respective quick fix action" lookup?
There was a problem hiding this comment.
this is the "show details" you click on to bring up on the additional info. When I'm working on the action stretch goal I'll find an alternative so the hover popup isn't too busy
...main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CustomTooltipOnHover.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CustomTooltipOnHover.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/azure/toolkit/intellij/azure/sdk/buildtool/CustomTooltipOnHover.java
Outdated
Show resolved
Hide resolved
| * The HTML content is styled using the styles.css file. | ||
| * One of the uses of this class is to create a tooltip with a recommendation text and a link to the Azure SDK for Java documentation. | ||
| */ | ||
| class QuickFixPanelConfigurations { |
There was a problem hiding this comment.
Should this be renamed inline with the CustomHoverTip.
I would rename to HoverTipPanel
| editorPane.setText(htmlContent); | ||
| editorPane.setEditable(false); | ||
| editorPane.setBackground(panel.getBackground()); | ||
| editorPane.setForeground(JBColor.LIGHT_GRAY); |
There was a problem hiding this comment.
could you add comments to where we made acccessibility improvements.
Include in javadocs for reference
| List<String> servicesToCheck = new ArrayList<>(); | ||
| Map<String, String> antiPatternMessageMap = new HashMap<>(); | ||
| List<String> listedItemsToCheck = new ArrayList<>(); | ||
| Map<String, String> recommendationTextMap = new HashMap<>(); | ||
| Map<String, String> recommendationLinkMap = new HashMap<>(); |
There was a problem hiding this comment.
Can these all now be updated to a better data structure?
What does this implement/fix? Explain your changes.
This class implements LocalQuickFix to create a custom quick fix that shows a tooltip with a recommendation text and a link to the Azure SDK for Java documentation.
Any relevant logs, screenshots, error output, etc.?
Any other comments?
…
Has this been tested?