Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle month ends for polars in time_ranges #43

Merged
merged 2 commits into from
Nov 23, 2023
Merged

handle month ends for polars in time_ranges #43

merged 2 commits into from
Nov 23, 2023

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Nov 23, 2023

Similar to #42, this makes sure that if the original times were month ends we return month ends when building a time range with polars.

@jmoralez jmoralez added the fix bug fix label Nov 23, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez changed the title handle month ends for polars in cv_times handle month ends for polars in time_ranges Nov 23, 2023
@jmoralez jmoralez marked this pull request as ready for review November 23, 2023 21:44
@jmoralez jmoralez merged commit 1e80030 into main Nov 23, 2023
17 checks passed
@jmoralez jmoralez deleted the month-ends-cv branch November 23, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant