Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppsspp-qt: Fix Qt wrapping #386712

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Mar 3, 2025

On master & nixos-24.11:

↪ /nix/store/l0viy52ldz8dp8jy26wv3i9485x2w06x-ppsspp-qt-1.18.1/bin/ppsspp 
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

fish: Job 1, '/nix/store/l0viy52ldz8dp8jy26wv…' terminated by signal SIGABRT (Aborted)

The necessary wrapper flags aren't being applied, because the makeWrapper call happens in postFixup which is after the automatic wrapping by wrapQtAppsHook. To fix this, and to avoid double-wrapping, disable the automatic wrapping & pass the wrapper args to the makeWrapper call.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 3, 2025
@Aleksanaa Aleksanaa merged commit 60a5731 into NixOS:master Mar 8, 2025
27 checks passed
@Aleksanaa Aleksanaa added the backport release-24.11 Backport PR automatically label Mar 8, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 8, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 8, 2025

Git push to origin failed for release-24.11 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants