Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maskprocessor: init at 0.73 #371349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

maskprocessor: init at 0.73 #371349

wants to merge 1 commit into from
+39 −0

Conversation

ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Jan 6, 2025 •
edited
Loading

Things done

Add missing package for #81418

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ethancedwards8 ethancedwards8 force-pushed the maskprocessor branch 2 times, most recently from 31acc01 to d6a927c Compare January 7, 2025 05:48
@ethancedwards8
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371349

x86_64-linux

✅ 1 package built:
  • maskprocessor

@ethancedwards8 ethancedwards8 requested a review from lucasew January 7, 2025 13:18
@ethancedwards8 ethancedwards8 force-pushed the maskprocessor branch 2 times, most recently from 05317ba to d9ec93c Compare January 7, 2025 13:27
@ethancedwards8
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371349

aarch64-darwin

✅ 1 package built:
  • maskprocessor

@ethancedwards8
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371349

x86_64-linux

✅ 1 package built:
  • maskprocessor

@ethancedwards8 ethancedwards8 requested a review from NickCao January 7, 2025 15:07
NickCao
NickCao reviewed Jan 7, 2025
View reviewed changes
pkgs/by-name/ma/maskprocessor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ma/maskprocessor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ma/maskprocessor/package.nix Outdated Show resolved Hide resolved
@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371349

x86_64-linux

✅ 1 package built:
  • maskprocessor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao left review comments

@lucasew lucasew Awaiting requested review from lucasew

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethancedwards8 @lucasew @NickCao