Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.nix #368864

Closed
wants to merge 575 commits into from
Closed

Conversation

IliyanKostov9
Copy link

Added ffmpeg dependency for viber (opening media in viber fails, due to missing ffmpeg)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

wineee and others added 30 commits December 28, 2024 15:11
This is old code, that will not change any time soon.
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment 6.topic: lua 6.topic: cinnamon Desktop environment 6.topic: docker tools 6.topic: vscode 6.topic: lib The Nixpkgs function library 6.topic: games 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: deepin Desktop environment and its components 6.topic: dotnet Language: .NET labels Dec 29, 2024
@nix-owners
Copy link

nix-owners bot commented Dec 29, 2024

The PR's base branch is set to nixos-unstable, but 439 commits from the haskell-updates branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the haskell-updates branch, change the base branch to haskell-updates
  • If the changes should go to the nixos-unstable branch, rebase your PR onto the merge base with the nixos-unstable branch:
    # git rebase --onto $(git merge-base upstream/nixos-unstable HEAD) $(git merge-base upstream/haskell-updates HEAD)
    git rebase --onto 634fd46801442d760e09493a794c4f15db2d0cbb a4cb0cad42ccf1b8fbe517721353e957bb314dfa
    git push --force-with-lease

@nix-owners
Copy link

nix-owners bot commented Dec 29, 2024

The PR's base branch is set to nixos-unstable, but 439 commits from the haskell-updates branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the haskell-updates branch, change the base branch to haskell-updates
  • If the changes should go to the nixos-unstable branch, rebase your PR onto the merge base with the nixos-unstable branch:
    # git rebase --onto $(git merge-base upstream/nixos-unstable HEAD) $(git merge-base upstream/haskell-updates HEAD)
    git rebase --onto 634fd46801442d760e09493a794c4f15db2d0cbb a4cb0cad42ccf1b8fbe517721353e957bb314dfa
    git push --force-with-lease

@IliyanKostov9 IliyanKostov9 deleted the patch-2 branch December 29, 2024 10:25
@github-actions github-actions bot added 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cinnamon Desktop environment 6.topic: deepin Desktop environment and its components 6.topic: docker tools 6.topic: dotnet Language: .NET 6.topic: games 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml 6.topic: php 6.topic: python 6.topic: vim 6.topic: vscode 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 5001+ 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.