Skip to content

frozen-bubble: fix build #353296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjornfor merged 3 commits into from
Nov 3, 2024
Merged

frozen-bubble: fix build #353296

bjornfor merged 3 commits into from
Nov 3, 2024

Conversation

@Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Nov 3, 2024 •
edited
Loading

kthakore/frozen-bubble#82

https://cache.nixos.org/log/4axpcdva2d55hzylsbp6405g81q4w0sw-perl5.40.0-frozen-bubble-2.212.drv

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2024
patka-123
patka-123 reviewed Nov 3, 2024
View reviewed changes
@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Nov 3, 2024

@patka-123 Done.

@Bot-wxt1221 Bot-wxt1221 requested a review from patka-123 November 3, 2024 10:21
patka-123
patka-123 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@patka-123 patka-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and can confirm it builds correctly now.

bjornfor
bjornfor reviewed Nov 3, 2024
View reviewed changes
@Bot-wxt1221 Bot-wxt1221 added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Nov 3, 2024
@bjornfor bjornfor merged commit 9eea3cb into NixOS:master Nov 3, 2024
@MaxHearnden MaxHearnden mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

+1 more reviewer

@patka-123 patka-123 patka-123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bot-wxt1221 @bjornfor @patka-123