Skip to content

unicodeit: init at 0.7.5 #341370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
natsukium merged 5 commits into from
Sep 14, 2024
Merged

unicodeit: init at 0.7.5 #341370

natsukium merged 5 commits into from
Sep 14, 2024

Conversation

@nicoonoclaste
Copy link
Contributor

@nicoonoclaste nicoonoclaste commented Sep 12, 2024 •
edited
Loading

Description of changes

  • Packaged python3.pkgs.unicodeit
  • Patched it (and sent a PR upstream) to expose the CLI entrypoint as a regular executable
  • Added a pkgs/by-name entry for users who just want the CLI

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Wrote and built package tests
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 12, 2024
@nicoonoclaste
Copy link
Contributor Author

nicoonoclaste commented Sep 12, 2024

Result of nixpkgs-review pr 341370 run on aarch64-darwin 1

@nicoonoclaste
Copy link
Contributor Author

nicoonoclaste commented Sep 12, 2024

Result of nixpkgs-review pr 341370 run on x86_64-linux 1

@nicoonoclaste
Copy link
Contributor Author

nicoonoclaste commented Sep 12, 2024 •
edited
Loading

That's odd, I'm not sure why nixpkgs-review didn't pick up on the new drvs, let's see whether @ofborg does

PS: Nevermind, it might be working as intended, only rebuilding drvs which changed... which doesn't include new ones.

mkg20001
mkg20001 reviewed Sep 12, 2024
View reviewed changes
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 12, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 13, 2024
natsukium
natsukium approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit e79f91f into NixOS:master Sep 14, 2024
@nicoonoclaste nicoonoclaste deleted the pkgs/unicodeit branch September 14, 2024 13:14
@nicoonoclaste
Copy link
Contributor Author

nicoonoclaste commented Sep 14, 2024 •
edited
Loading

@natsukium Sorry, I should have said something: since the PR included fixup! commits, I was planning on doing a no-diff rebase prior to merging. It's no big issue though, don't worry. ^^

Anyhow, thanks for the review & merge.

name-snrl pushed a commit to name-snrl/nixpkgs that referenced this pull request Sep 16, 2024
@nicoonoclaste @name-snrl
unicodeit: init at 0.7.5 (NixOS#341370)
f048f52 
* python3.pkgs.unicodeit: init at 0.7.5

* python3.pkgs.unicodeit: define CLI entrypoint

* unicodeit: init

* fixup! python3.pkgs.unicodeit: define CLI entrypoint

* fixup! python3.pkgs.unicodeit: init at 0.7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkg20001 mkg20001 mkg20001 approved these changes

@natsukium natsukium natsukium approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicoonoclaste @mkg20001 @natsukium @wegank