-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
cctag: init at 1.0.3 #216402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cctag: init at 1.0.3 #216402
Conversation
|
Waiting for #217585 to land in master |
|
Result of 1 package built:
|
|
Result of 3 packages built:
|
davidak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
Builds, can't test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| outputs = [ "lib" "dev" "out" ]; | |
| outputs = [ "out" "lib" "dev" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really a good idea? cctag.out is empty (it's only included because some hooks complain otherwise). cctag.lib really is the main binary output.
If cctag.lib were to go first, building cctag would default to an empty output which would be somewhat counterintuitive.
Not sure if there are any policies surrounding this other than "binaries should go first"
|
@davidak I'm reasonably confident that CI should run fine on Darwin now (let's see in a few minutes). |
Description of changes
Add package for the CCTag library.
Links:
Depends on PR #215689
Part of an ongoing effort to package Meshroom (#94127). See also #215528 #215728 #216401 #216399
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)