Skip to content

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 5, 2023

https://www.intel.com/content/www/us/en/developer/articles/release-notes/intel-oneapi-threading-building-blocks-release-notes.html\
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.5.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.6.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.7.0

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice February 5, 2023 15:01
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 5, 2023
@mweinelt
Copy link
Member Author

mweinelt commented Feb 5, 2023

Mixed results. Have to go through them once more I guess.

8 packages marked as broken and skipped:
  • openvino
  • python310Packages.openvino
  • python310Packages.rlax
  • python310Packages.tiledb
  • python310Packages.worldengine
  • python311Packages.openvino
  • python311Packages.tiledb
  • python311Packages.worldengine
1 package blacklisted:
  • appimage-run-tests
106 packages failed to build:
  • altair
  • anki-bin
  • anytype
  • appimage-run
  • betterdiscord-installer
  • bootstrap-studio
  • buttercup-desktop
  • caprine-bin
  • cider
  • cloudcompare
  • cozy-drive
  • crypto-org-wallet
  • devdocs-desktop
  • electron-mail
  • electronplayer
  • elmerfem
  • embree2
  • firefly-desktop
  • flexoptix-app
  • fluent-reader
  • framesh
  • fspy
  • horizon-eda
  • houdini
  • ikos
  • inkcut
  • inkscape-extensions.inkcut
  • irccloud
  • keet
  • kodiPackages.steam-launcher
  • lbry
  • ldtk
  • ledger-live-desktop
  • lens
  • linuxKernel.packages.linux_4_14_hardened.sysdig
  • linuxKernel.packages.linux_4_19_hardened.sysdig
  • logseq
  • losslesscut-bin
  • lunar-client
  • lutris
  • mathpix-snipping-tool
  • mendeley
  • minigalaxy
  • mirtk
  • mobilecoin-wallet
  • molotov
  • motrix
  • museeks
  • neo4j-desktop
  • notion-app-enhanced
  • nuclear
  • opencascade
  • openimagedenoise_1_2_x
  • osmscout-server
  • osrm-backend
  • osu-lazer-bin
  • p3x-onenote
  • paraview
  • passky-desktop
  • perl534Packages.Tirex
  • perl536Packages.Tirex
  • playonlinux
  • protontricks
  • prusa-slicer
  • pureref
  • python310Packages.asf-search
  • python310Packages.enamlx
  • python310Packages.pythonocc-core
  • python311Packages.asf-search
  • python311Packages.enamlx
  • python311Packages.hepmc3
  • python311Packages.plotnine
  • python311Packages.python-mapnik
  • python311Packages.pythonocc-core
  • radicle-upstream
  • rambox
  • raven-reader
  • remnote
  • saleae-logic-2
  • session-desktop
  • smesh
  • sonixd
  • ssb-patchwork
  • standardnotes
  • steam
  • steam-rom-manager
  • steam-run
  • steam-tui
  • steamcmd
  • super-slicer-latest
  • t-rex
  • timeular
  • trezor-suite
  • uhk-agent
  • uhk-udev-rules
  • unityhub
  • via
  • vial
  • wootility
  • wpsoffice
  • wpsoffice-cn
  • xivlauncher
  • youtube-music
  • ytmdesktop
  • zecwallet-lite
  • zulip
102 packages built:
  • Sylk
  • apacheHttpdPackages.mod_tile
  • beekeeper-studio
  • blender
  • blender-hip
  • bloomrpc
  • bowtie2
  • chrysalis
  • easyeffects
  • embree
  • entwine
  • gdal (python310Packages.gdal)
  • gmt
  • gplates
  • grass
  • hepmc3
  • joplin-desktop
  • libLAS
  • linuxKernel.packages.linux_4_14.sysdig
  • linuxKernel.packages.linux_4_19.sysdig
  • linuxKernel.packages.linux_5_10.sysdig
  • linuxKernel.packages.linux_5_10_hardened.sysdig
  • linuxKernel.packages.linux_5_15.sysdig
  • linuxKernel.packages.linux_hardened.sysdig (linuxKernel.packages.linux_5_15_hardened.sysdig)
  • linuxKernel.packages.linux_5_4.sysdig
  • linuxKernel.packages.linux_6_1.sysdig
  • linuxKernel.packages.linux_6_1_hardened.sysdig
  • linuxKernel.packages.linux_latest_libre.sysdig
  • linuxKernel.packages.linux_libre.sysdig
  • linuxKernel.packages.linux_lqx.sysdig
  • linuxKernel.packages.linux_testing_bcachefs.sysdig
  • linuxKernel.packages.linux_xanmod.sysdig
  • linuxKernel.packages.linux_xanmod_latest.sysdig (linuxKernel.packages.linux_xanmod_stable.sysdig)
  • linuxKernel.packages.linux_zen.sysdig
  • mapcache
  • mapnik
  • mapproxy
  • mapserver
  • marktext
  • merkaartor
  • mycrypto
  • mysql-workbench
  • notable
  • octant-desktop
  • openimagedenoise
  • openorienteering-mapper
  • openturns
  • openvdb
  • pagmo2
  • pdal
  • plexamp
  • polypane
  • postgresql11Packages.postgis
  • postgresql12Packages.postgis
  • postgresql13Packages.postgis
  • postgresql14Packages.postgis
  • postgresql15Packages.postgis
  • potreeconverter
  • python310Packages.bpycv
  • python310Packages.bsuite
  • python310Packages.cartopy
  • python310Packages.fiona
  • python310Packages.folium
  • python310Packages.geopandas
  • python310Packages.hepmc3
  • python310Packages.openturns
  • python310Packages.osmnx
  • python310Packages.plotnine
  • python310Packages.pygmo
  • python310Packages.pygmt
  • python310Packages.python-mapnik
  • python310Packages.rasterio
  • python310Packages.wktutils
  • python311Packages.cartopy
  • python311Packages.fiona
  • python311Packages.folium
  • python311Packages.gdal
  • python311Packages.geopandas
  • python311Packages.openturns
  • python311Packages.osmnx
  • python311Packages.pygmt
  • python311Packages.rasterio
  • python311Packages.wktutils
  • pytrainer
  • qgis
  • qgis-ltr
  • qmapshack
  • root
  • saga
  • station
  • sumo
  • super-slicer
  • sysdig
  • tbb
  • tiledb
  • tracy
  • tusk
  • udig
  • vcmi
  • xfitter
  • yoda-with-root
  • zettlr

@mweinelt
Copy link
Member Author

mweinelt commented Feb 5, 2023

The build fails horribly on i686-linux. 🙈

tbb-i686-linux> [ 47%] Building CXX object test/CMakeFiles/test_join_node_msg_key_matching.dir/tbb/test_join_node_msg_key_matching.cpp.o
tbb-i686-linux> during RTL pass: expand
tbb-i686-linux> In file included from /build/source/src/tbb/../../include/tbb/flow_graph.h:17,
tbb-i686-linux>                  from /build/source/test/tbb/test_flow_graph_whitebox.cpp:35:
tbb-i686-linux> /build/source/src/tbb/../../include/tbb/../oneapi/tbb/flow_graph.h: In member function 'bool tbb::detail::d1::limiter_node<int, int>::_ZThn20_N3tbb6detail2d112limiter_nodeIiiE18register_successorERNS1_8receiverIiEE.artificial_thunk.0(tbb::detail::d1::limiter_node<int, int>::successor_type&)':
tbb-i686-linux> /build/source/src/tbb/../../include/tbb/../oneapi/tbb/flow_graph.h:2032:38: internal compiler error: in expand_expr_real_1, at expr.c:10281
tbb-i686-linux>  2032 |         spin_mutex::scoped_lock lock(my_mutex);
tbb-i686-linux>       |                                      ^~~~~~~~
tbb-i686-linux> 0x93484a9 diagnostic_impl(rich_location*, diagnostic_metadata const*, int, char const*, char**, diagnostic_t)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x934866b internal_error(char const*, ...)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x82b3e15 fancy_abort(char const*, int, char const*)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8280e37 expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool) [clone .cold]
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x863cd83 expand_operands(tree_node*, tree_node*, rtx_def*, rtx_def**, rtx_def**, expand_modifier)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x864a6da expand_expr_real_2(separate_ops*, rtx_def*, machine_mode, expand_modifier)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8638c2e expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8642645 expand_expr_addr_expr_1(tree_node*, rtx_def*, scalar_int_mode, expand_modifier, unsigned char)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x86423af expand_expr_addr_expr_1(tree_node*, rtx_def*, scalar_int_mode, expand_modifier, unsigned char)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x86388c3 expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8644e65 store_expr(tree_node*, rtx_def*, int, bool, bool)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8646578 expand_assignment(tree_node*, tree_node*, bool) [clone .part.0]
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x853b06a expand_gimple_stmt(gimple*)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x85417e9 (anonymous namespace)::pass_expand::execute(function*)
tbb-i686-linux> 	???:0
tbb-i686-linux> Please submit a full bug report,
tbb-i686-linux> with preprocessed source if appropriate.
tbb-i686-linux> Please include the complete backtrace with any bug report.
tbb-i686-linux> See <https://gcc.gnu.org/bugs/> for instructions.
tbb-i686-linux> make[2]: *** [test/CMakeFiles/test_flow_graph_whitebox.dir/build.make:76: test/CMakeFiles/test_flow_graph_whitebox.dir/tbb/test_flow_graph_whitebox.cpp.o] Error 1
tbb-i686-linux> make[1]: *** [CMakeFiles/Makefile2:1558: test/CMakeFiles/test_flow_graph_whitebox.dir/all] Error 2
tbb-i686-linux> make[1]: *** Waiting for unfinished jobs....
tbb-i686-linux> during RTL pass: expand
tbb-i686-linux> In file included from /build/source/src/tbb/../../include/tbb/flow_graph.h:17,
tbb-i686-linux>                  from /build/source/test/tbb/test_eh_flow_graph.cpp:25:
tbb-i686-linux> /build/source/src/tbb/../../include/tbb/../oneapi/tbb/flow_graph.h: In member function 'bool tbb::detail::d1::input_node<std::tuple<int, int> >::_ZThn16_N3tbb6detail2d110input_nodeISt5tupleIJiiEEE18register_successorERNS1_8receiverIS4_EE.artificial_thunk.0(tbb::detail::d1::input_node<std::tuple<int, int> >::successor_type&)':
tbb-i686-linux> /build/source/src/tbb/../../include/tbb/../oneapi/tbb/flow_graph.h:594:38: internal compiler error: in expand_expr_real_1, at expr.c:10281
tbb-i686-linux> 0x93484a9 diagnostic_impl(rich_location*, diagnostic_metadata const*, int, char const*, char**, diagnostic_t)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x934866b internal_error(char const*, ...)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x82b3e15 fancy_abort(char const*, int, char const*)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8280e37 expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool) [clone .cold]
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x863cd83 expand_operands(tree_node*, tree_node*, rtx_def*, rtx_def**, rtx_def**, expand_modifier)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x864a6da expand_expr_real_2(separate_ops*, rtx_def*, machine_mode, expand_modifier)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8638c2e expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8642645 expand_expr_addr_expr_1(tree_node*, rtx_def*, scalar_int_mode, expand_modifier, unsigned char)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x86423af expand_expr_addr_expr_1(tree_node*, rtx_def*, scalar_int_mode, expand_modifier, unsigned char)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x86388c3 expand_expr_real_1(tree_node*, rtx_def*, machine_mode, expand_modifier, rtx_def**, bool)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8644e65 store_expr(tree_node*, rtx_def*, int, bool, bool)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x8646578 expand_assignment(tree_node*, tree_node*, bool) [clone .part.0]
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x853b06a expand_gimple_stmt(gimple*)
tbb-i686-linux> 	???:0
tbb-i686-linux> 0x85417e9 (anonymous namespace)::pass_expand::execute(function*)
tbb-i686-linux> 	???:0
tbb-i686-linux> Please submit a full bug report,
tbb-i686-linux> with preprocessed source if appropriate.
tbb-i686-linux> Please include the complete backtrace with any bug report.
tbb-i686-linux> See <https://gcc.gnu.org/bugs/> for instructions.
tbb-i686-linux> make[2]: *** [test/CMakeFiles/test_eh_flow_graph.dir/build.make:76: test/CMakeFiles/test_eh_flow_graph.dir/tbb/test_eh_flow_graph.cpp.o] Error 1
tbb-i686-linux> make[1]: *** [CMakeFiles/Makefile2:1480: test/CMakeFiles/test_eh_flow_graph.dir/all] Error 2
tbb-i686-linux> [ 48%] Linking CXX executable ../gnu_11.3_cxx11_32_release/test_indexer_node
tbb-i686-linux> [ 48%] Built target test_indexer_node
tbb-i686-linux> [ 48%] Linking CXX executable ../gnu_11.3_cxx11_32_release/test_join_node_msg_key_matching
tbb-i686-linux> [ 48%] Built target test_join_node_msg_key_matching
tbb-i686-linux> [ 48%] Linking CXX executable ../gnu_11.3_cxx11_32_release/test_join_node_key_matching
tbb-i686-linux> [ 48%] Built target test_join_node_key_matching
tbb-i686-linux> [ 49%] Linking CXX executable ../gnu_11.3_cxx11_32_release/test_join_node
tbb-i686-linux> [ 49%] Built target test_join_node
tbb-i686-linux> make: *** [Makefile:166: all] Error 2
error: builder for '/nix/store/c9bisy0as3qa6lhzwgvr7jhjv4xdcmlf-tbb-2021.8.0.drv' failed with exit code 2;

@jtojnar
Copy link
Member

jtojnar commented Feb 6, 2023

See also #195401 and #109113, there has been a lot of breakage in Nixpkgs and also https://github.com/lopsided98/nix-ros-overlay (e.g. gazebosim/gazebo-classic#2867).

@hesiod
Copy link
Contributor

hesiod commented Feb 10, 2023

I've created a PR #215689 (based on this PR) that splits TBB into versioned packages in order to minimize breakage while still allowing to use TBB 2021.8 as a dependency (some packages require this).

davidak pushed a commit to hesiod/nixpkgs that referenced this pull request Feb 18, 2023
This is based on PR NixOS#214762 by @mweinelt.

For the new release 2021.8, see
https://www.intel.com/content/www/us/en/developer/articles/release-notes/intel-oneapi-threading-building-blocks-release-notes.html
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.5.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.6.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.7.0

Due to the significant breakage due to the update to TBB 2021.8, instead
split the tbb package into tbb_2020_3 and tbb_2021_8, with the default
tbb aliased to tbb_2020_3 in order to minimize breakage.
davidak pushed a commit to davidak/nixpkgs that referenced this pull request Feb 18, 2023
This is based on PR NixOS#214762.

For the new release 2021.8, see
https://www.intel.com/content/www/us/en/developer/articles/release-notes/intel-oneapi-threading-building-blocks-release-notes.html
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.5.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.6.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.7.0

Due to the significant breakage due to the update to TBB 2021.8, instead
split the tbb package into tbb_2020_3 and tbb_2021_8, with the default
tbb aliased to tbb_2020_3 in order to minimize breakage.

Co-Authored-By: Martin Weinelt <[email protected]>
@mweinelt
Copy link
Member Author

mweinelt commented Feb 20, 2023

Closed in favor of #217585

@mweinelt mweinelt closed this Feb 20, 2023
@mweinelt mweinelt deleted the tbb-2021.8.0 branch February 20, 2023 14:17
davidak added a commit to davidak/nixpkgs that referenced this pull request Feb 21, 2023
This is based on PR NixOS#214762.

For the new release 2021.8, see
https://www.intel.com/content/www/us/en/developer/articles/release-notes/intel-oneapi-threading-building-blocks-release-notes.html
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.5.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.6.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.7.0

Due to the significant breakage due to the update to TBB 2021.8, instead
split the tbb package into tbb_2020_3 and tbb_2021_8, with the default
tbb aliased to tbb_2020_3 in order to minimize breakage.

Co-Authored-By: Martin Weinelt <[email protected]>
Co-Authored-By: davidak <[email protected]>
davidak added a commit to davidak/nixpkgs that referenced this pull request Mar 2, 2023
This is based on PR NixOS#214762.

For the new release 2021.8, see
https://www.intel.com/content/www/us/en/developer/articles/release-notes/intel-oneapi-threading-building-blocks-release-notes.html
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.5.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.6.0
https://github.com/oneapi-src/oneTBB/releases/tag/v2021.7.0

Due to the significant breakage due to the update to TBB 2021.8, instead
split the tbb package into tbb_2020_3 and tbb_2021_8, with the default
tbb aliased to tbb_2020_3 in order to minimize breakage.

Also fixed build issues and improved code.

Co-Authored-By: Martin Weinelt <[email protected]>
Co-Authored-By: davidak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants