Skip to content

torrenttools: init at 0.6.2 #196070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Nov 8, 2022
Merged

torrenttools: init at 0.6.2 #196070

SuperSandro2000 merged 1 commit into from
Nov 8, 2022

Conversation

@azahi
Copy link
Member

@azahi azahi commented Oct 15, 2022 •
edited by SuperSandro2000
Loading

Description of changes

Fixes #195881

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@azahi
Copy link
Member Author

azahi commented Oct 15, 2022

I intend to split these changes in multiple commits (and probably multiple PRs) in the near future.

@azahi
Copy link
Member Author

azahi commented Oct 15, 2022 •
edited
Loading

Waiting for these PRs to be merged first:

Optionally wait for #195401: it would allow us to use TBB's CMake module.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 15, 2022
@ofborg ofborg bot requested a review from r-burns October 15, 2022 16:35
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 15, 2022
ghost
ghost suggested changes Oct 16, 2022
View reviewed changes
@azahi azahi force-pushed the torrenttools branch 3 times, most recently from 2dab597 to 7140a61 Compare October 16, 2022 16:15
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 2, 2022
@azahi azahi force-pushed the torrenttools branch 2 times, most recently from 601ad33 to d978ad1 Compare November 3, 2022 08:35
@azahi azahi mentioned this pull request Nov 3, 2022
Merged
13 tasks
@AndersonTorres
Copy link
Member

AndersonTorres commented Nov 4, 2022

I believe bencode can be PRed in separate. What do you think?

@azahi
Copy link
Member Author

azahi commented Nov 5, 2022

I believe bencode can be PRed in separate. What do you think?

Alright, let's make it so #199662.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 5, 2022
@azahi azahi requested review from a user and AndersonTorres November 7, 2022 21:07
@azahi azahi marked this pull request as ready for review November 7, 2022 21:08
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 7, 2022
@nixos-discourse
Copy link

nixos-discourse commented Nov 8, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1384

@SuperSandro2000 SuperSandro2000 merged commit f0fc13c into NixOS:master Nov 8, 2022
@azahi azahi deleted the torrenttools branch March 7, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-burns r-burns Awaiting requested review from r-burns

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torrenttools

4 participants

@azahi @AndersonTorres @nixos-discourse @SuperSandro2000